You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is some issue with the static-linking feature. It seems like some crates are requesting dynamic-linking by default. Once we are selecting static-linking inside this repo, but some external crates select dynamically-linking, we have a cudarc both dynamically and statically linked, which is not allowed.
Hey @michaelfeil thanks a lot for this PR, as already mentioned we're directly working with candle to make sure that the linking strategy doesn't default to dynamic-linking for neither cudarc nor intel-mkl-src so that we can simply bump candle without having to rely on a fork to "remove" the default linking strategy. I'll ping you on the candle PR later today, but once that's done IMO we can bump candle here too, and eventually add support for Flash Attention 3 as per your PR at #785, thanks again and sorry for the inconvenience 🤗
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/michaelfeil/candle-extensions-fork -> Can be PR'ed and merged into huggingface's candle fork.