Skip to content

candle upgrade to 0.9.2alpha2#784

Closed
michaelfeil wants to merge 6 commits intohuggingface:mainfrom
michaelfeil:mf/new-candle
Closed

candle upgrade to 0.9.2alpha2#784
michaelfeil wants to merge 6 commits intohuggingface:mainfrom
michaelfeil:mf/new-candle

Conversation

@michaelfeil
Copy link
Copy Markdown
Contributor

@michaelfeil michaelfeil commented Dec 22, 2025

  • upgrades candle to latest rc
  • I feel like ~5% overall improvements in performance.

https://github.com/michaelfeil/candle-extensions-fork -> Can be PR'ed and merged into huggingface's candle fork.

@alvarobartt alvarobartt self-requested a review December 22, 2025 15:29
@alvarobartt alvarobartt added this to the v1.9.0 milestone Dec 22, 2025
@michaelfeil michaelfeil changed the title Mf/new candle candle upgrade to 0.9.2rc2 Dec 28, 2025
@michaelfeil michaelfeil changed the title candle upgrade to 0.9.2rc2 candle upgrade to 0.9.2alpha2 Dec 28, 2025
@michaelfeil
Copy link
Copy Markdown
Contributor Author

There is some issue with the static-linking feature. It seems like some crates are requesting dynamic-linking by default. Once we are selecting static-linking inside this repo, but some external crates select dynamically-linking, we have a cudarc both dynamically and statically linked, which is not allowed.

@alvarobartt
Copy link
Copy Markdown
Member

Hey @michaelfeil thanks a lot for this PR, as already mentioned we're directly working with candle to make sure that the linking strategy doesn't default to dynamic-linking for neither cudarc nor intel-mkl-src so that we can simply bump candle without having to rely on a fork to "remove" the default linking strategy. I'll ping you on the candle PR later today, but once that's done IMO we can bump candle here too, and eventually add support for Flash Attention 3 as per your PR at #785, thanks again and sorry for the inconvenience 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants