Improve Unigram tokenization performance for long inputs#34
Open
bepsvpt wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Unigram tokenizes text, it creates the remaining string for every character:
For long input, this copies a lot of characters and the total work becomes
O(n²).This PR changes
common_prefix_searchto use the original character array with a start offset. It avoids creating a new suffix string every time.The token scores and Viterbi logic are not changed.
Benchmark
Tested on the same machine with Node.js 26.5.0. Each case ran 3 times and the table shows the median time.
Before this change, the time is close to 4x when the input size doubles. After this change, it is around 2x.
Tests
AI assistance
AI tools were used for this PR: