Respect HF_ENDPOINT for env.remoteHost#1713
Open
slandau3 wants to merge 1 commit into
Open
Conversation
b1c54c8 to
4d18e12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Some enterprise deployments route Hugging Face traffic through an internal proxy or self-hosted Hub, for example to allow only approved models. Today, Transformers.js initializes
env.remoteHosttohttps://huggingface.co/, so Node.js users targeting those deployments need to overrideenv.remoteHostmanually in code.Change
This changes the default to read
process.env.HF_ENDPOINTwhen present, and fall back tohttps://huggingface.co/otherwise. This follows the existing environment variable pattern used for Hub auth tokens while preserving the current default behavior.Tests
Adds a focused
env.test.jscovering both the fallback andHF_ENDPOINTcases.