Skip to content

Allow all origins for Cross-Origin Storage#1716

Merged
xenova merged 2 commits into
huggingface:mainfrom
tomayac:patch-1
Jul 8, 2026
Merged

Allow all origins for Cross-Origin Storage#1716
xenova merged 2 commits into
huggingface:mainfrom
tomayac:patch-1

Conversation

@tomayac

@tomayac tomayac commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

This makes the resources available globally. Initially this wasn't implemented in the extension, but the origins check is implemented now, so we need to update the code to make use of it. (Internally, the extension as a one-off upgrades all resources that were stored already as origins: '*'.)

@tomayac

tomayac commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

By the way, we also now offer TypeScript types.

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@xenova

xenova commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR!

build fails with:

Error: src/utils/cache/CrossOriginStorageCache.js(115,13): error TS2353: Object literal may only specify known properties, and 'origins' does not exist in type 'CrossOriginStorageRequestFileHandleOptions'.
 ELIFECYCLE  Command failed with exit code 1.
/home/runner/_work/transformers.js/transformers.js/packages/transformers:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @huggingface/transformers@4.2.0 build: `node scripts/build.mjs && pnpm typegen`
Exit status 1
 ELIFECYCLE  Command failed with exit code 1.
Error: Process completed with exit code 1.

seems that we should update types?

@tomayac tomayac requested a review from nico-martin July 8, 2026 11:27

@xenova xenova left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ thanks!

@xenova xenova merged commit 353007b into huggingface:main Jul 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants