WIP: Initial support for bnb 4bit on any nn.Parameter#39859
Draft
matthewdouglas wants to merge 8 commits intomainfrom
Draft
WIP: Initial support for bnb 4bit on any nn.Parameter#39859matthewdouglas wants to merge 8 commits intomainfrom
matthewdouglas wants to merge 8 commits intomainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
cc @MekkCyber |
SunMarc
reviewed
Aug 7, 2025
Member
SunMarc
left a comment
There was a problem hiding this comment.
Nice it would be great to add some tests (inference / saving) with gptoss model !
78d55b3 to
61fdac5
Compare
2131f9b to
19a008f
Compare
19a008f to
fbf3044
Compare
fbf3044 to
23934d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new option to
BitsAndBytesConfigcalledtarget_parameterswith the same spirit astarget_parametersin huggingface/peft#2638. The intent is to allow quantization ofnn.Parameterthat are not within ann.Linear, e.g. those found commonly in certain MoE model implementations.Requires bitsandbytes-foundation/bitsandbytes#1720 which is released in bitsandbytes v0.48.0.
Example usage with a Granite MoE:
Memory Usage - BF16
Memory Usage - Before PR
Memory Usage - After PR
Before submitting
Pull Request section?
to it if that's the case.
(See Slack discussion)
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@SunMarc @MekkCyber @BenjaminBossan