[Qwen3MoE] Fix wrong return type annotation in Qwen3MoeSparseMoeBlock.forward#45211
Closed
matdou wants to merge 2 commits intohuggingface:mainfrom
Closed
[Qwen3MoE] Fix wrong return type annotation in Qwen3MoeSparseMoeBlock.forward#45211matdou wants to merge 2 commits intohuggingface:mainfrom
matdou wants to merge 2 commits intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: qwen3_moe, qwen3_omni_moe, qwen3_vl_moe |
a0a6199 to
2c36a74
Compare
Member
|
No drive-by code agent PRs on other people's issues please! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45208
What does this PR do?
This PR corrects an incorrect return type in
Qwen3MoeSparseMoeBlock.forward.The method was annotated as returning
tuple[torch.Tensor, torch.Tensor], while the implementation returns atorch.Tensor:In particular, downstream usage (e.g. in
Qwen3MoeDecoderLayer) expects a tensor:This PR updates the annotation to:
in both:
modeling_qwen3_moe.pymodular_qwen3_moe.pyNo functional changes are introduced, this is a typing correction only.
Checklist
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @Cyrilvallez