feat: make timesfm2_5 onnx export compatible#45233
Open
pdufour wants to merge 6 commits intohuggingface:mainfrom
Open
feat: make timesfm2_5 onnx export compatible#45233pdufour wants to merge 6 commits intohuggingface:mainfrom
pdufour wants to merge 6 commits intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: timesfm, timesfm2_5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes an issue with the padding logic in the forward pass for timesfm not being Onnx export compatible.
Specifically this condition:
Will give this error when you try to export the timesfm module through
torch.onnx.exportThe solution is to refactor
_preprocessto a branch-free path as seen in this PR.Test Plan
On main, create a test file in the repo root
text_onnx_export.py:
Run the export which will export the timesfm2_5 model to onnx
This gives you the following errors:
This is the line:
Now checkout this branch
Run the export again:
See that it passes!
Run a test:
Create a file test_onnx_infer.py
Run it:
Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@xenova @zucchini-nlp @Cyrilvallez @ArthurZucker @vasqu @NielsRogge