Fix UnboundLocalError in invert_attention_mask by adding proper shape…#45247
Open
gagandhakrey wants to merge 2 commits intohuggingface:mainfrom
Open
Fix UnboundLocalError in invert_attention_mask by adding proper shape…#45247gagandhakrey wants to merge 2 commits intohuggingface:mainfrom
gagandhakrey wants to merge 2 commits intohuggingface:mainfrom
Conversation
added 2 commits
April 5, 2026 09:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… validation
What does this PR do?
Problem The invert_attention_mask function in src/transformers/modeling_utils.py crashed with an UnboundLocalError when given an encoder_attention_mask shape that wasn't exactly 2D or 3D. Because it only checked for 2D and 3D shapes using separate if statements without any elif or else fallback, the encoder_extended_attention_mask variable would remain unassigned before attempting a .to() cast, causing models with 1D or 4D inputs to fail silently with confusing stack traces.
Fix Refactored the second conditional check to use an elif and added a final else branch. If the passed tensor is neither 2D nor 3D, it now explicitly raises a ValueError detailing the incorrect tensor shape, matching the behavior of the nearby get_extended_attention_mask function and preventing the UnboundLocalError entirely.
Fixes # (issue)
Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.