Use inspect.getsource instead of open() for source-reading in _can_set_*_implementation#46207
Open
rasmi wants to merge 1 commit into
Open
Use inspect.getsource instead of open() for source-reading in _can_set_*_implementation#46207rasmi wants to merge 1 commit into
rasmi wants to merge 1 commit into
Conversation
6 tasks
Cyrilvallez
reviewed
May 27, 2026
Cyrilvallez
left a comment
Cyrilvallez
left a comment
Member
There was a problem hiding this comment.
Hey! Just some remarks to clean the code a bit
Comment on lines
+2081
to
+2082
| def _nn_classes_in_defining_module(cls, *, name_contains: str | None = None) -> list[type] | None: | ||
| """Return `nn.Module` subclasses defined in `cls`'s module, or None if the module isn't loaded.""" |
Member
There was a problem hiding this comment.
Let's not create a function for this
Comment on lines
+2105
to
+2108
| return any( | ||
| "ALL_ATTENTION_FUNCTIONS" in getattr(getattr(attn_cls, "forward", None), "__globals__", {}) | ||
| for attn_cls in attention_classes | ||
| ) |
Member
There was a problem hiding this comment.
Let's use inspect.getsource here instead
Contributor
Author
There was a problem hiding this comment.
Thanks @Cyrilvallez -- I did this approach becuase @zucchini-nlp seemed unhappy with the source-reading + regex approach here but I think tightening up the regex will at least give equivalent results (see discrepancy here).
rasmi
force-pushed
the
can-set-impl-introspection
branch
from
bafc137 to
88d216a
Compare
rasmi
force-pushed
the
can-set-impl-introspection
branch
from
88d216a to
dd767df
Compare
rasmi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoid
open()-reading transformers' own.pysource inmodeling_utils.py(alongside #46152). This is helpful for hermetic Python builds (e.g. with Bazel) and other non-standard environments (as opposed toopen()which can vary based on the precise environment and filesystem).Changes
_nn_classes_in_defining_modulehelper onPreTrainedModel; rewrites the two_can_set_attn_implementation/_can_set_experts_implementationchecks to use it. The new checks test the same property as before (does this model use the modern attention / experts interface?) but inspect livenn.Modulesubclasses instead of grepping the file text.Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@zucchini-nlp @Rocketknight1 @Cyrilvallez