fix: resolve integration test failures by migrating COCO image loading to HF Hub fixtures#47219
Conversation
This reverts commit 2bb6882.
CI recapDashboard: View test results in Grafana
|
|
[For maintainers] Suggested jobs to run (before merge) run-slow: aimv2, aria, deepseek_vl_hybrid, eomt, eomt_dinov3, fast_vlm, flava, fuyu, idefics, imagegpt, kimi_k25, layoutlmv2, lfm2_vl, llava, minimax_m3_vl, pix2struct |
|
@ydshieh In src/transformers/modeling_utils.py, we are using the index 3f14d74979..f27ae1d884 100644
--- a/src/transformers/modeling_utils.py
+++ b/src/transformers/modeling_utils.py
@@ -982,7 +982,7 @@ class ModuleUtilsMixin:
torch.ones((batch_size, seq_length, prefix_seq_len), device=device, dtype=causal_mask.dtype),
causal_mask,
],
- axis=-1,
+ dim=-1,
)
extended_attention_mask = causal_mask[:, None, :, :] * attention_mask[:, None, None, :]This is causing local typing check to fail. |
|
run-slow: aimv2, aria, deepseek_vl_hybrid, eomt, eomt_dinov3, fast_vlm, flava, fuyu, idefics, imagegpt, kimi_k25, layoutlmv2, lfm2_vl, llava, minimax_m3_vl, pix2struct |
|
This comment contains models: ["models/aimv2", "models/aria", "models/deepseek_vl_hybrid", "models/eomt", "models/eomt_dinov3", "models/fast_vlm", "models/flava", "models/fuyu", "models/idefics", "models/imagegpt", "models/kimi_k25", "models/layoutlmv2", "models/lfm2_vl", "models/llava", "models/minimax_m3_vl", "models/pix2struct"] |
|
Sorry I just realized that work was started earlier at #47218 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
This PR resolves the integration test failures triaged in #47205.
The domain
images.cocodataset.orghas been unstable, resulting in connection timeouts and failing integration tests across multiple model pipelines. To address this, we have migrated COCO-dataset image loading in our test suites to use the mirrored fixtures on the Hugging Face Hub underhf-internal-testing/fixtures-cocoand utilizing local path redirection.Key Changes:
load_test_imageintests/test_processing_common.pywhich wrapsload_imageand automatically processes remote URLs withurl_to_local_path.requests.getorhttpx.gettargetinghttp://images.cocodataset.org/val2017/000000039769.jpgto the newload_test_imagehelper pointing to the Hugging Face mirror.images.cocodataset.orgURLs from theURLS_FOR_TESTING_DATAregistry inutils/fetch_hub_objects_for_ci.py.This prevents flaky network issues and leverages local caching during CI execution.
Related Issues
Fixes #47205
Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. These often are low-quality, or fix extremely minor issues that occur rarely or never in practice.
As a result, we're instituting a rule that first-time contributors should not use code agents to submit PRs or issues.
We'd also ask autonomous "OpenClaw"-like agents not to open any PRs or issues.
Issues/PRs from first-time contributors that violate this rule will probably just be closed without review, and we
might block you, especially if you open more than one or appear to be deliberately ignoring this. We especially do not
want new contributors to jump in on random issues to contribute an agent-written fix. This creates lots of noise
for reviewers and other users and will almost certainly get you blocked.
For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request checks?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.