pip install -e ".[dev]" fails on macOS: liger-kernel requires triton#6327
Open
clementtisseau wants to merge 1 commit into
Open
pip install -e ".[dev]" fails on macOS: liger-kernel requires triton#6327clementtisseau wants to merge 1 commit into
clementtisseau wants to merge 1 commit into
Conversation
kashif
approved these changes
Jul 8, 2026
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
ligeranddevextras list liger-kernel unconditionally. liger-kernel is pure Python, but requirestriton>=2.3.1, and triton ships manylinux wheels only, no sdist, no macOS/Windows wheels. With nothing to install andnothing to build, the resolver fails before the install phase, so nothing lands at all.
Windows is affected too.
Skipping liger-kernel on macOS costs nothing: Triton kernels can't run there,
is_liger_kernel_available()already guards the runtime path, andrequire_liger_kernelalready skips the tests.
Before submitting
AI writing disclosure
We welcome the use of AI tools to help with contributions. For transparency and to help us improve our review process, please indicate the level of AI involvement in this PR.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.
Note
Low Risk
Packaging-only change with no runtime code paths modified; Linux installs keep the same dependency set.
Overview
Fixes
pip install -e ".[dev]"(and.[liger]) failing on macOS and Windows by adding asys_platform == 'linux'marker onliger-kernelin both theligeranddevoptional dependency groups.liger-kernelpulls in Triton, which only publishes Linux wheels, so unconditional inclusion made the resolver fail before any packages installed. On non-Linux platforms this matches existing behavior: Liger/Triton kernels are not usable there, and availability checks plusrequire_liger_kernelalready skip runtime and test paths when the package is absent.Reviewed by Cursor Bugbot for commit 18adad0. Bugbot is set up for automated code reviews on this repo. Configure here.