feat(data): add optional source_range to download_stream#724
Closed
kszucs wants to merge 2 commits into
Closed
Conversation
Member
Author
|
@hoytak please review |
Collaborator
|
Nice! The API is getting moved to the xet session interface, but I made sure the new stream api had this. See #729. |
Collaborator
|
Implemented with testing and unified interface as part of #735 |
Member
Author
|
Great, thanks! Closing in favor of #735 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source_range: Option<Range<u64>>parameter toFileDownloadSession::download_streamNone, behaviour is unchanged (full file streaming)Some(range), the stream is reconstructed for the given byte range onlytest_utils.rsto passNoneat the existing call siteMotivation
Required by the Apache OpenDAL HuggingFace backend (apache/opendal#7185) to support efficient range reads (e.g. reading Parquet footers) over the XET CAS protocol without downloading the full file.