Commit 38c987c
committed
Seed test_pink_ik env and bump G1 rotation tolerance to 0.100 rad
The unset seed in create_test_env meant the same forward_waist_bending
case produced different IK convergence residuals (0.055 rad locally,
0.086 rad in CI) -- making it impossible to choose a safe tolerance
threshold by local observation alone.
Two fixes together:
1) Set env_cfg.seed=42 so the convergence residual is reproducible
across runs and machines. The warning "Seed not set for the
environment. The environment creation may not be deterministic."
from manager_based_env is now gone.
2) Bump G1 rotation tolerance from 0.080 rad (4.6 deg) to 0.100 rad
(5.7 deg) in pink_ik_g1_test_configs.json. Under seed=42 the
hardest case (forward_waist_bending_movement on
FixedBaseUpperBodyIK-G1) deterministically reaches 0.086491 rad
steady-state residual -- the QP equilibrium where wrist
FrameTasks (cost 8/4) balance against NullSpacePostureTask
regulating the waist joints (cost 0.05). 0.100 rad gives ~14 pct
margin and stays well below the threshold at which pick-and-place
behavior degrades (typical grasp tolerance is 5-10 deg).
GR1T2 tolerance is unchanged at 0.020 rad; GR1T2 converges to ~1e-4
rad with the existing settings.1 parent 4fdc11b commit 38c987c
3 files changed
Lines changed: 16 additions & 21 deletions
File tree
- source/isaaclab
- changelog.d
- test/controllers
- test_ik_configs
Lines changed: 13 additions & 20 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
| 71 | + | |
70 | 72 | | |
71 | 73 | | |
72 | 74 | | |
| |||
0 commit comments