You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[Docs] Tighten BaseArticulation docstrings to interface contract
Removed consumer-name leakage from the abstract-method docstrings on
BaseArticulation (get_jacobians / get_mass_matrix /
get_gravity_compensation_forces). Base-class API docs should declare
what the method is and the cross-backend contract -- not which
controllers consume the result, which conditions trigger fetches, or
how the underlying view differs from the new accessor.
What's removed:
- "Used by OperationalSpaceController when ..."
- "Task-space controllers (IK, OSC, RMPFlow) slice this array ..."
- "Callers should use this instead of root_view.get_jacobians()"
- "callers should gate this method behind their own feature flag"
- The wordy "concrete with NotImplementedError so out-of-tree
backends..." paragraph -- that's an internal convention, not API
contract for callers.
What stays / was tightened:
- The J . q_dot identity defining the contract.
- Backend-implementer requirement that COM-referenced native
Jacobians MUST shift to link origin before returning.
- Floating-base joint-dim caveat (a real cross-backend contract
difference), reworded without naming PhysX / Newton specifically.
- Mass matrix doc: state the equation of motion role of M(q).
- Gravity comp doc: state the static-equilibrium contract for g(q).
Also tightened two adjacent sites that named consumers in
implementation comments:
- shift_jacobian_com_to_origin kernel docstring no longer says "PhysX
(and the IK/OSC controllers)"; refers to the BaseArticulation
contract directly.
- Newton _create_buffers comment: "jacobian buffers for task-space
controllers (IK, OSC, RMPFlow)" -> "jacobian buffers backing
get_jacobians".
0 commit comments