Skip to content

Commit 4f7dd10

Browse files
authored
Added rendering test for ovphysx (isaac-sim#5794)
# Description Added rendering test for ovphysx. Only the cartpole env is supported, so we skip testing for the other two envs. ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
1 parent cebcb35 commit 4f7dd10

18 files changed

Lines changed: 137 additions & 26 deletions

.github/workflows/build.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -699,7 +699,7 @@ jobs:
699699
isaacsim-base-image: ${{ needs.config.outputs.isaacsim_image_name }}
700700
isaacsim-version: ${{ needs.config.outputs.isaacsim_image_tag }}
701701
filter-pattern: "isaaclab_tasks"
702-
extra-pip-packages: "ovrtx"
702+
extra-pip-packages: "ovrtx ovphysx"
703703
include-files: "test_rendering_cartpole_kitless.py,test_rendering_dexsuite_kuka_kitless.py,test_rendering_shadow_hand_kitless.py"
704704
container-name: isaac-lab-rendering-correctness-kitless-test
705705
#endregion

.github/workflows/daily-compatibility.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ jobs:
111111
image-tag: ${{ env.DOCKER_IMAGE_TAG }}
112112
pytest-options: ""
113113
filter-pattern: "isaaclab_tasks"
114-
extra-pip-packages: "ovrtx"
114+
extra-pip-packages: "ovrtx ovphysx"
115115

116116
- name: Copy All Test Results from IsaacLab Tasks Container
117117
run: |

source/isaaclab_tasks/changelog.d/huidongc-add-ovphysx-rendering-test.skip

Whitespace-only changes.
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading

0 commit comments

Comments
 (0)