Skip to content

Commit e1eb51a

Browse files
committed
Fix migration syntax to Hydra-style key=value selectors
The cartpole deprecation warnings, env_cfg docstrings, regression-test fixtures, and changelog fragment all referenced the typed preset CLI as ``--presets=NAME`` / ``--physics`` / ``--renderer``. The preset CLI landed with Hydra-style ``key=value`` tokens (no leading dashes); the dashed form was an intermediate iteration that did not ship. Corrects every touchpoint so users following the deprecation warning copy a command that actually parses: * runtime DeprecationWarning messages in the 4 consolidated env_cfg modules now say ``presets=<name>`` (still ``--task=`` since that is a real argparse flag); * test_cartpole_preset_deprecations fixtures and docstrings updated to match; * docstrings/comments in the env_cfg modules and the showcase __init__.py; * changelog fragment.
1 parent 9a558ed commit e1eb51a

7 files changed

Lines changed: 54 additions & 54 deletions

File tree

source/isaaclab_tasks/changelog.d/jichuanh-cartpole-presets.minor.rst

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,18 @@ Added
66
(``rgb``, ``depth``, ``albedo``, ``semantic_segmentation``,
77
``simple_shading_constant_diffuse``, ``simple_shading_diffuse_mdl``,
88
``simple_shading_full_mdl``), renderer backend, and physics backend at
9-
runtime via the typed preset CLI flags (``--physics``, ``--renderer``,
10-
``--presets``).
9+
runtime via the Hydra-style preset selectors from #5587 (``physics=NAME``,
10+
``renderer=NAME``, ``presets=NAME[,NAME,...]``; no leading dashes).
1111
* Added :data:`Isaac-Cartpole-Camera-v0` -- consolidated manager-based
1212
perception cartpole task. Selects the observation pipeline
1313
(``rgb``, ``depth``, ``resnet18``, ``theia_tiny``) and physics backend at
14-
runtime via ``--presets`` / ``--physics``. The two ``rl_games`` agent
14+
runtime via ``presets=`` / ``physics=``. The two ``rl_games`` agent
1515
yamls live under ``rl_games_cfg_entry_point`` (image policy, default) and
1616
``rl_games_feature_cfg_entry_point`` (pretrained-feature policy); pick via
1717
``--agent <name>``.
1818
* Added :data:`Isaac-Cartpole-Showcase-Direct-v0` -- consolidated
1919
proprioceptive showcase task that selects the (observation, action) gym
20-
space combination at runtime via ``--presets=<obs>_<action>``. All 15
20+
space combination at runtime via ``presets=<obs>_<action>``. All 15
2121
combinations of ``{box, discrete, multidiscrete, dict, tuple}`` observation
2222
and ``{box, discrete, multidiscrete}`` action are registered as variants.
2323
The matching ``skrl`` policy yaml is exposed as
@@ -30,28 +30,28 @@ Deprecated
3030
^^^^^^^^^^
3131

3232
* Deprecated the per-variant Direct-backend perception task IDs in favor of
33-
:data:`Isaac-Cartpole-Camera-Direct-v0` with ``--presets=<name>``. Each
33+
:data:`Isaac-Cartpole-Camera-Direct-v0` with ``presets=<name>``. Each
3434
retired ID still loads but emits a :class:`DeprecationWarning` pointing at
3535
the new invocation:
3636

3737
* ``Isaac-Cartpole-Camera-Presets-Direct-v0`` -> ``Isaac-Cartpole-Camera-Direct-v0``
38-
* ``Isaac-Cartpole-RGB-Camera-Direct-v0`` -> ``Isaac-Cartpole-Camera-Direct-v0 --presets=rgb``
39-
* ``Isaac-Cartpole-Depth-Camera-Direct-v0`` -> ``Isaac-Cartpole-Camera-Direct-v0 --presets=depth``
40-
* ``Isaac-Cartpole-Albedo-Camera-Direct-v0`` -> ``Isaac-Cartpole-Camera-Direct-v0 --presets=albedo``
41-
* ``Isaac-Cartpole-SimpleShading-Constant-Camera-Direct-v0`` -> ``Isaac-Cartpole-Camera-Direct-v0 --presets=simple_shading_constant_diffuse``
42-
* ``Isaac-Cartpole-SimpleShading-Diffuse-Camera-Direct-v0`` -> ``Isaac-Cartpole-Camera-Direct-v0 --presets=simple_shading_diffuse_mdl``
43-
* ``Isaac-Cartpole-SimpleShading-Full-Camera-Direct-v0`` -> ``Isaac-Cartpole-Camera-Direct-v0 --presets=simple_shading_full_mdl``
38+
* ``Isaac-Cartpole-RGB-Camera-Direct-v0`` -> ``Isaac-Cartpole-Camera-Direct-v0 presets=rgb``
39+
* ``Isaac-Cartpole-Depth-Camera-Direct-v0`` -> ``Isaac-Cartpole-Camera-Direct-v0 presets=depth``
40+
* ``Isaac-Cartpole-Albedo-Camera-Direct-v0`` -> ``Isaac-Cartpole-Camera-Direct-v0 presets=albedo``
41+
* ``Isaac-Cartpole-SimpleShading-Constant-Camera-Direct-v0`` -> ``Isaac-Cartpole-Camera-Direct-v0 presets=simple_shading_constant_diffuse``
42+
* ``Isaac-Cartpole-SimpleShading-Diffuse-Camera-Direct-v0`` -> ``Isaac-Cartpole-Camera-Direct-v0 presets=simple_shading_diffuse_mdl``
43+
* ``Isaac-Cartpole-SimpleShading-Full-Camera-Direct-v0`` -> ``Isaac-Cartpole-Camera-Direct-v0 presets=simple_shading_full_mdl``
4444

4545
* Deprecated the per-variant manager-based perception task IDs in favor of
46-
:data:`Isaac-Cartpole-Camera-v0` with ``--presets=<name>``:
46+
:data:`Isaac-Cartpole-Camera-v0` with ``presets=<name>``:
4747

48-
* ``Isaac-Cartpole-RGB-v0`` -> ``Isaac-Cartpole-Camera-v0 --presets=rgb``
49-
* ``Isaac-Cartpole-Depth-v0`` -> ``Isaac-Cartpole-Camera-v0 --presets=depth``
50-
* ``Isaac-Cartpole-RGB-ResNet18-v0`` -> ``Isaac-Cartpole-Camera-v0 --presets=resnet18``
51-
* ``Isaac-Cartpole-RGB-TheiaTiny-v0`` -> ``Isaac-Cartpole-Camera-v0 --presets=theia_tiny``
48+
* ``Isaac-Cartpole-RGB-v0`` -> ``Isaac-Cartpole-Camera-v0 presets=rgb``
49+
* ``Isaac-Cartpole-Depth-v0`` -> ``Isaac-Cartpole-Camera-v0 presets=depth``
50+
* ``Isaac-Cartpole-RGB-ResNet18-v0`` -> ``Isaac-Cartpole-Camera-v0 presets=resnet18 --agent rl_games_feature_cfg_entry_point``
51+
* ``Isaac-Cartpole-RGB-TheiaTiny-v0`` -> ``Isaac-Cartpole-Camera-v0 presets=theia_tiny --agent rl_games_feature_cfg_entry_point``
5252

5353
* Deprecated the 15 per-shape proprioceptive showcase task IDs in favor of
54-
:data:`Isaac-Cartpole-Showcase-Direct-v0` with ``--presets=<obs>_<action>``
54+
:data:`Isaac-Cartpole-Showcase-Direct-v0` with ``presets=<obs>_<action>``
5555
and ``--agent skrl_<obs>_<action>_cfg_entry_point``. Each retired ID
5656
(``Isaac-Cartpole-Showcase-{Box,Discrete,MultiDiscrete,Dict,Tuple}-{Box,Discrete,MultiDiscrete}-Direct-v0``)
5757
still loads but emits a :class:`DeprecationWarning` pointing at the new
@@ -60,4 +60,4 @@ Deprecated
6060
* Deprecated the 9 per-shape camera-based showcase task IDs in favor of
6161
:data:`Isaac-Cartpole-Camera-Showcase-Direct-v0`. Each retired ID
6262
(``Isaac-Cartpole-Camera-Showcase-{Box,Dict,Tuple}-{Box,Discrete,MultiDiscrete}-Direct-v0``)
63-
emits a ``DeprecationWarning`` with the matching ``--presets=<obs>_<action>``.
63+
emits a ``DeprecationWarning`` with the matching ``presets=<obs>_<action>``.

source/isaaclab_tasks/isaaclab_tasks/direct/cartpole/cartpole_camera_presets_env_cfg.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class CartpoleTiledCameraCfg(CameraCfg):
5858

5959
# Per-variant 180-degree offset -- matches the historical
6060
# CartpoleAlbedoCameraEnvCfg / CartpoleSimpleShading{Constant,Diffuse,Full}CameraEnvCfg
61-
# so the deprecated task IDs and ``--presets=<name>`` against the consolidated
61+
# so the deprecated task IDs and ``presets=<name>`` against the consolidated
6262
# task return identical cfg shape (including camera orientation).
6363
_ROTATED_OFFSET = CameraCfg.OffsetCfg(pos=(-5.0, 0.0, 2.0), rot=(1.0, 0.0, 0.0, 0.0), convention="world")
6464
albedo = CartpoleTiledCameraCfg(data_types=["albedo"], offset=_ROTATED_OFFSET)
@@ -133,7 +133,7 @@ class BaseCartpoleCameraEnvCfg(DirectRLEnvCfg):
133133
# through these factories instead of their old per-variant cfg classes. Each
134134
# factory emits a :class:`DeprecationWarning` pointing at the consolidated
135135
# :data:`Isaac-Cartpole-Camera-Direct-v0` task with the equivalent
136-
# ``--presets=<name>`` invocation, then returns the corresponding variant of
136+
# ``presets=<name>`` invocation, then returns the corresponding variant of
137137
# :class:`CartpoleCameraPresetsEnvCfg` so existing behavior is preserved.
138138

139139

@@ -158,7 +158,7 @@ def _deprecated_factory(old_task_id: str, preset_name: str | None = None):
158158

159159
def factory():
160160
new_id = "Isaac-Cartpole-Camera-Direct-v0"
161-
tail = f"--task={new_id}" + (f" --presets={preset_name}" if preset_name else "")
161+
tail = f"--task={new_id}" + (f" presets={preset_name}" if preset_name else "")
162162
warnings.warn(
163163
f"Task '{old_task_id}' is deprecated and will be removed in a future release. Use {tail}.",
164164
DeprecationWarning,
@@ -171,7 +171,7 @@ def factory():
171171
# this, the shim leaves ``tiled_camera`` as the nested PresetCfg whose
172172
# default is rgb -- so e.g. the deprecated albedo task would load the
173173
# albedo observation_space with an rgb data_types camera, and a stray
174-
# ``--presets=X`` would also override the camera independently of the
174+
# ``presets=X`` would also override the camera independently of the
175175
# root. ``MultiDataTypeCartpoleTiledCameraCfg`` exposes the same set of
176176
# variant names as ``CartpoleCameraPresetsEnvCfg``, so the same key
177177
# selects both consistently.

source/isaaclab_tasks/isaaclab_tasks/direct/cartpole_showcase/cartpole/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
# space combination via the preset CLI (#5587). Each of the 15 retired IDs
2020
# below routes through a deprecation factory in
2121
# ``cartpole_showcase_presets_env_cfg`` that points at this task with the
22-
# equivalent ``--presets=<obs>_<action>``. The default skrl yaml matches the
22+
# equivalent ``presets=<obs>_<action>``. The default skrl yaml matches the
2323
# canonical ``box_box`` shape; for other variants pass the matching
2424
# ``--agent skrl_<obs>_<action>_cfg_entry_point``.
2525
gym.register(
@@ -54,7 +54,7 @@
5454
# -- Deprecated aliases --------------------------------------------------------
5555
# Each retired task ID routes its env_cfg_entry_point through a deprecation
5656
# factory in cartpole_showcase_presets_env_cfg that emits a
57-
# DeprecationWarning naming the consolidated task + equivalent --presets value.
57+
# DeprecationWarning naming the consolidated task + equivalent presets= value.
5858

5959
###
6060
# Observation space as Box

source/isaaclab_tasks/isaaclab_tasks/direct/cartpole_showcase/cartpole/cartpole_showcase_presets_env_cfg.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
88
Wraps the 15 per-(observation, action) cfg classes in :mod:`cartpole_env_cfg`
99
into a single :class:`PresetCfg` so the ``Isaac-Cartpole-Showcase-Direct-v0``
10-
task can switch between them at runtime via ``--presets=<obs>_<action>``
10+
task can switch between them at runtime via ``presets=<obs>_<action>``
1111
(the typed preset CLI from #5587). Each retired showcase task ID routes its
1212
``env_cfg_entry_point`` through one of the deprecation factories below.
1313
@@ -73,7 +73,7 @@ class CartpoleShowcasePresetsEnvCfg(PresetCfg):
7373
"""Proprioceptive cartpole showcase with selectable observation/action space.
7474
7575
Each variant attribute is an instance of an existing per-shape cfg class.
76-
The hydra resolver picks one based on the ``--presets=<name>`` CLI token;
76+
The hydra resolver picks one based on the ``presets=<name>`` CLI token;
7777
the default is ``box_box`` (matching the canonical cartpole shape).
7878
"""
7979

@@ -107,7 +107,7 @@ def _deprecated_factory(old_task_id: str, preset_name: str):
107107
retired showcase task ID. On invocation it emits a
108108
``DeprecationWarning`` pointing at the consolidated
109109
``Isaac-Cartpole-Showcase-Direct-v0`` task with the equivalent
110-
``--presets=<preset_name>``, then returns a fresh instance of the
110+
``presets=<preset_name>``, then returns a fresh instance of the
111111
corresponding per-shape cfg class so the retired task keeps loading a
112112
working cfg until removal.
113113
@@ -123,7 +123,7 @@ def factory():
123123
new_id = "Isaac-Cartpole-Showcase-Direct-v0"
124124
warnings.warn(
125125
f"Task '{old_task_id}' is deprecated and will be removed in a future release. "
126-
f"Use --task={new_id} --presets={preset_name}.",
126+
f"Use --task={new_id} presets={preset_name}.",
127127
DeprecationWarning,
128128
stacklevel=2,
129129
)

source/isaaclab_tasks/isaaclab_tasks/direct/cartpole_showcase/cartpole_camera/cartpole_camera_showcase_presets_env_cfg.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
88
Wraps the 9 per-(observation, action) cfg classes in :mod:`cartpole_camera_env_cfg`
99
into a single :class:`PresetCfg` so the ``Isaac-Cartpole-Camera-Showcase-Direct-v0``
10-
task can switch between them at runtime via ``--presets=<obs>_<action>``.
10+
task can switch between them at runtime via ``presets=<obs>_<action>``.
1111
Each retired showcase task ID routes its ``env_cfg_entry_point`` through one
1212
of the deprecation factories below. The companion ``skrl`` policy yaml is
1313
variant-specific; all 9 yamls are registered as parallel agent entry points
@@ -54,7 +54,7 @@ class CartpoleCameraShowcasePresetsEnvCfg(PresetCfg):
5454
"""Camera-based cartpole showcase with selectable observation container and action space.
5555
5656
Each variant attribute is an instance of an existing per-shape cfg class.
57-
The hydra resolver picks one based on ``--presets=<name>``; the default
57+
The hydra resolver picks one based on ``presets=<name>``; the default
5858
is ``box_box`` (matching the canonical cartpole camera shape).
5959
"""
6060

@@ -82,7 +82,7 @@ def _deprecated_factory(old_task_id: str, preset_name: str):
8282
retired showcase task ID. On invocation it emits a
8383
``DeprecationWarning`` pointing at the consolidated
8484
``Isaac-Cartpole-Camera-Showcase-Direct-v0`` task with the equivalent
85-
``--presets=<preset_name>``, then returns a fresh instance of the
85+
``presets=<preset_name>``, then returns a fresh instance of the
8686
corresponding per-shape cfg class.
8787
8888
Args:
@@ -97,7 +97,7 @@ def factory():
9797
new_id = "Isaac-Cartpole-Camera-Showcase-Direct-v0"
9898
warnings.warn(
9999
f"Task '{old_task_id}' is deprecated and will be removed in a future release. "
100-
f"Use --task={new_id} --presets={preset_name}.",
100+
f"Use --task={new_id} presets={preset_name}.",
101101
DeprecationWarning,
102102
stacklevel=2,
103103
)

source/isaaclab_tasks/isaaclab_tasks/manager_based/classic/cartpole/cartpole_camera_presets_env_cfg.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
:class:`CartpoleDepthCameraEnvCfg`, :class:`CartpoleResNet18CameraEnvCfg`,
1010
:class:`CartpoleTheiaTinyCameraEnvCfg`) in a single :class:`PresetCfg` so the
1111
``Isaac-Cartpole-Camera-v0`` task can switch between them at runtime via
12-
``--presets=<name>`` (the typed preset CLI from #5587). Each retired task ID
12+
``presets=<name>`` (the typed preset CLI from #5587). Each retired task ID
1313
(``Isaac-Cartpole-{RGB,Depth,RGB-ResNet18,RGB-TheiaTiny}-v0``) routes its
1414
``env_cfg_entry_point`` through one of the deprecation factories below.
1515
"""
@@ -44,10 +44,10 @@ class CartpoleCameraPresetsEnvCfg(PresetCfg):
4444
backbone from the RGB camera.
4545
4646
The variant attributes hold concrete env cfg instances, so the hydra
47-
resolver picks one based on ``--presets=<name>`` (or the broadcast
48-
``--presets`` CSV) and the rest of the cfg tree is inherited from
49-
:class:`CartpoleEnvCfg`, including the existing ``CartpolePhysicsCfg``
50-
that powers the ``--physics`` typed flag.
47+
resolver picks one based on ``presets=<name>`` (or the broadcast
48+
``presets=<name>,<name>,...`` CSV) and the rest of the cfg tree is
49+
inherited from :class:`CartpoleEnvCfg`, including the existing
50+
``CartpolePhysicsCfg`` that powers the ``physics=`` typed selector.
5151
"""
5252

5353
default = CartpoleRGBCameraEnvCfg()
@@ -80,7 +80,7 @@ def _deprecated_factory(old_task_id: str, preset_name: str | None = None):
8080

8181
def factory():
8282
new_id = "Isaac-Cartpole-Camera-v0"
83-
tail = f"--task={new_id}" + (f" --presets={preset_name}" if preset_name else "")
83+
tail = f"--task={new_id}" + (f" presets={preset_name}" if preset_name else "")
8484
warnings.warn(
8585
f"Task '{old_task_id}' is deprecated and will be removed in a future release. Use {tail}.",
8686
DeprecationWarning,

source/isaaclab_tasks/test/test_cartpole_preset_deprecations.py

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
consolidated cfg. These tests lock that contract:
1212
1313
* Every retired task ID emits a ``DeprecationWarning`` exactly once that
14-
names the new consolidated task ID and the corresponding ``--presets`` name.
14+
names the new consolidated task ID and the corresponding ``presets=`` name.
1515
* The new ``Isaac-Cartpole-Camera-Direct-v0`` and ``Isaac-Cartpole-Camera-v0``
1616
task IDs load cleanly with no deprecation warning of our own.
1717
@@ -34,36 +34,36 @@
3434
# (deprecated task id, expected migration suffix appearing in the warning body)
3535
_DIRECT_DEPRECATIONS = [
3636
("Isaac-Cartpole-Camera-Presets-Direct-v0", "--task=Isaac-Cartpole-Camera-Direct-v0"),
37-
("Isaac-Cartpole-RGB-Camera-Direct-v0", "--task=Isaac-Cartpole-Camera-Direct-v0 --presets=rgb"),
38-
("Isaac-Cartpole-Depth-Camera-Direct-v0", "--task=Isaac-Cartpole-Camera-Direct-v0 --presets=depth"),
39-
("Isaac-Cartpole-Albedo-Camera-Direct-v0", "--task=Isaac-Cartpole-Camera-Direct-v0 --presets=albedo"),
37+
("Isaac-Cartpole-RGB-Camera-Direct-v0", "--task=Isaac-Cartpole-Camera-Direct-v0 presets=rgb"),
38+
("Isaac-Cartpole-Depth-Camera-Direct-v0", "--task=Isaac-Cartpole-Camera-Direct-v0 presets=depth"),
39+
("Isaac-Cartpole-Albedo-Camera-Direct-v0", "--task=Isaac-Cartpole-Camera-Direct-v0 presets=albedo"),
4040
(
4141
"Isaac-Cartpole-SimpleShading-Constant-Camera-Direct-v0",
42-
"--task=Isaac-Cartpole-Camera-Direct-v0 --presets=simple_shading_constant_diffuse",
42+
"--task=Isaac-Cartpole-Camera-Direct-v0 presets=simple_shading_constant_diffuse",
4343
),
4444
(
4545
"Isaac-Cartpole-SimpleShading-Diffuse-Camera-Direct-v0",
46-
"--task=Isaac-Cartpole-Camera-Direct-v0 --presets=simple_shading_diffuse_mdl",
46+
"--task=Isaac-Cartpole-Camera-Direct-v0 presets=simple_shading_diffuse_mdl",
4747
),
4848
(
4949
"Isaac-Cartpole-SimpleShading-Full-Camera-Direct-v0",
50-
"--task=Isaac-Cartpole-Camera-Direct-v0 --presets=simple_shading_full_mdl",
50+
"--task=Isaac-Cartpole-Camera-Direct-v0 presets=simple_shading_full_mdl",
5151
),
5252
]
5353

5454
_MANAGER_DEPRECATIONS = [
55-
("Isaac-Cartpole-RGB-v0", "--task=Isaac-Cartpole-Camera-v0 --presets=rgb"),
56-
("Isaac-Cartpole-Depth-v0", "--task=Isaac-Cartpole-Camera-v0 --presets=depth"),
57-
("Isaac-Cartpole-RGB-ResNet18-v0", "--task=Isaac-Cartpole-Camera-v0 --presets=resnet18"),
58-
("Isaac-Cartpole-RGB-TheiaTiny-v0", "--task=Isaac-Cartpole-Camera-v0 --presets=theia_tiny"),
55+
("Isaac-Cartpole-RGB-v0", "--task=Isaac-Cartpole-Camera-v0 presets=rgb"),
56+
("Isaac-Cartpole-Depth-v0", "--task=Isaac-Cartpole-Camera-v0 presets=depth"),
57+
("Isaac-Cartpole-RGB-ResNet18-v0", "--task=Isaac-Cartpole-Camera-v0 presets=resnet18"),
58+
("Isaac-Cartpole-RGB-TheiaTiny-v0", "--task=Isaac-Cartpole-Camera-v0 presets=theia_tiny"),
5959
]
6060

6161
# Proprioceptive cartpole showcase: 15 (observation, action) shape combinations
62-
# collapse into Isaac-Cartpole-Showcase-Direct-v0 via --presets=<obs>_<action>.
62+
# collapse into Isaac-Cartpole-Showcase-Direct-v0 via presets=<obs>_<action>.
6363
_PROPRIO_SHOWCASE_DEPRECATIONS = [
6464
(
6565
f"Isaac-Cartpole-Showcase-{obs_label}-{act_label}-Direct-v0",
66-
f"--task=Isaac-Cartpole-Showcase-Direct-v0 --presets={obs}_{act}",
66+
f"--task=Isaac-Cartpole-Showcase-Direct-v0 presets={obs}_{act}",
6767
)
6868
for obs_label, obs in [
6969
("Box", "box"),
@@ -77,11 +77,11 @@
7777

7878
# Camera-based cartpole showcase: 9 (observation, action) shape combinations
7979
# collapse into Isaac-Cartpole-Camera-Showcase-Direct-v0 via
80-
# --presets=<obs>_<action>.
80+
# presets=<obs>_<action>.
8181
_CAMERA_SHOWCASE_DEPRECATIONS = [
8282
(
8383
f"Isaac-Cartpole-Camera-Showcase-{obs_label}-{act_label}-Direct-v0",
84-
f"--task=Isaac-Cartpole-Camera-Showcase-Direct-v0 --presets={obs}_{act}",
84+
f"--task=Isaac-Cartpole-Camera-Showcase-Direct-v0 presets={obs}_{act}",
8585
)
8686
for obs_label, obs in [("Box", "box"), ("Dict", "dict"), ("Tuple", "tuple")]
8787
for act_label, act in [("Box", "box"), ("Discrete", "discrete"), ("MultiDiscrete", "multidiscrete")]
@@ -110,7 +110,7 @@ def _load_capturing_task_deprecations(task_id: str) -> list[str]:
110110
)
111111
def test_retired_task_id_emits_deprecation_pointing_at_new_task(task_id: str, migration: str) -> None:
112112
"""Each retired cartpole perception task ID emits a DeprecationWarning
113-
that names the consolidated task and the equivalent ``--presets`` value."""
113+
that names the consolidated task and the equivalent ``presets=`` value."""
114114
messages = _load_capturing_task_deprecations(task_id)
115115
assert len(messages) == 1, f"{task_id}: expected 1 task-deprecation warning, got {len(messages)}: {messages}"
116116
body = messages[0]

0 commit comments

Comments
 (0)