Make the styles not broken in 6.2#175
Open
jazzsequence wants to merge 1 commit into
Open
Conversation
The `.welcome-panel` class gets some new styling in 6.2 which makes the text virtually unreadable (black on dark blue). This PR flips the colors and adds some padding. Have not tested to see if these styles are enqueued globally but I don't _think_ they are (looks like they're just [here](https://github.com/humanmade/WordPress-Importer/blob/master/templates/import.php)), but if this does affect things outside the importing page, a class could be added to the [`welcome-panel` div](https://github.com/humanmade/WordPress-Importer/blob/master/templates/import.php#L34) wrapper to specify that it's a `wp-import welcome-panel` and then these CSS rules could be applied to `wp-import.welcome-panel` or just `wp-import`.
Author
|
With updated styles: Without |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.welcome-panelclass gets some new styling in 6.2 which makes the text virtually unreadable (black on dark blue). This PR flips the colors and adds some padding. Have not tested to see if these styles are enqueued globally but I don't think they are (looks like they're just here), but if this does affect things outside the importing page, a class could be added to thewelcome-paneldiv wrapper to specify that it's awp-import welcome-paneland then these CSS rules could be applied towp-import.welcome-panelor justwp-import.