Removing MySQL 8.0 as default from local server#971
Conversation
filter182
commented
Jul 2, 2026
filter182
commented
- Delivera https://github.com/humanmade/product-dev/issues/2185
wisyhambolu
left a comment
wisyhambolu
left a comment
There was a problem hiding this comment.
A few comments need to be removed. We should avoid commenting out code as it creates noise within the codebase.
Also, 8.0 references need to be removed in https://github.com/humanmade/altis-local-server/blob/master/docs/database.md also which are missed from this PR.
| // Suppress mysql_native_password deprecation warning | ||
| // Only affects in-place upgrades from MySQL 5.7 to 8.0. | ||
| 'command' => $version === '8.0' ? '--log-error-suppression-list=MY-013360' : '', | ||
| //'command' => $version === '8.0' ? '--log-error-suppression-list=MY-013360' : '', |
There was a problem hiding this comment.
This should not be commented out but rather removed.
There was a problem hiding this comment.
I'll close this PR as you mentioned in the ticket that this should be a separated PRs, doing this on that PR
| // Suppress mysql_native_password deprecation warning | ||
| // Only affects in-place upgrades from MySQL 5.7 to 8.0. |
There was a problem hiding this comment.
These need to be removed also as they a re 8.0 specific.
|
@filter182 JC, One thing that is always useful is to connect a PR to the ticket it addresses via the Zenhub widget. You'll need the Zenhub browser extension or view the PR in Zenhub. It makes a direct link to the PR from the Zenhub board. After: |
@mikelittle I think I did that but I was getting the message that I needed to re-auth that extension which it seems that it didn't work, also in other instances I have the issue that it doesn't allow me to liking because it simply doesn't show the ticket to be lined with |
3 participants
