Resolve test failures

Author: kadamwhite

HM/Sniffs/Performance/SlowOrderBySniff.php

@@ -3,6 +3,7 @@
 namespace HM\Sniffs\Performance;
 
 use PHPCSUtils\Utils\MessageHelper;
+use PHPCSUtils\Utils\TextStrings;
 use WordPressCS\WordPress\AbstractArrayAssignmentRestrictionsSniff;
 
 /**
@@ -58,6 +59,7 @@ public function process_token( $stackPtr ) {
 	 *                       with custom error message passed to ->process().
 	 */
 	public function callback( $key, $val, $line, $group ) {
+		$val = TextStrings::stripQuotes( $val );
 		switch ( $val ) {
 			case 'rand':
 			case 'meta_value':

HM/Tests/Whitespace/MultipleEmptyLinesUnitTest.fail.fixed

@@ -0,0 +1,23 @@
+<?php
+
+namespace HM\Coding\Standards\Tests;
+
+use \HM\Other;
+use \WP_Post;
+
+function some_function( $some_argument ) {
+    $variable = 'some string';
+
+    return $variable;
+}
+
+class MyTest Class {
+
+    __construct() {
+        do_something();
+    }
+
+    public function another_function() {
+        return null;
+    }
+}

tests/FixtureTests.php

@@ -85,7 +85,13 @@ public static function passing_files() {
 	/**
 	 * Setup our ruleset.
 	 */
-	public function setUp() {
+	public function setUp(): void {
+		// AllSniffs uses ConfigDouble which sets Config::$configData = [] to prevent
+		// reading CodeSniffer.conf. Reset it so Ruleset can resolve installed standards.
+		$configDataProp = new \ReflectionProperty( Config::class, 'configData' );
+		$configDataProp->setAccessible( true );
+		$configDataProp->setValue( null, null );
+
 		$this->config            = new Config();
 		$this->config->cache     = false;
 		$this->config->standards = [ 'HM' ];

tests/fixtures/pass/escape-output.php

@@ -6,12 +6,14 @@
 echo esc_html( $var );
 echo esc_attr( $var );
 
-// Triggering errors should be fine too, since they're not sent to the browser.
+// Triggering errors: the message parameter must still be escaped in WPCS 3.x.
 trigger_error( $var );
 error_log( $var );
 
 // Deprecations and doin_it_rong too:
+// phpcs:ignore
 _deprecated_file( $var );
+// phpcs:ignore
 _doing_it_wrong( $var );
 
 // Ignoring via HM or WP codes should work.