Skip to content

fix(ci): always run release cleanup on failure #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaysin586 merged 1 commit into from
May 28, 2026
Merged

fix(ci): always run release cleanup on failure #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ jobs:
pnpm publish --provenance --access public --no-git-checks

- name: Cleanup on failure
if: failure() && steps.create_release.outcome == 'success'
if: failure()
env:
RELEASE_VERSION: ${{ steps.version.outputs.new_version }}
GITHUB_TOKEN: ${{ secrets.ACTIONS_KEY }}
Expand All @@ -526,9 +526,9 @@ jobs:
fi

# Proceed with cleanup only if validation passes
gh release delete "$RELEASE_VERSION" --yes
git tag -d "$RELEASE_VERSION"
git push --delete origin "$RELEASE_VERSION"
gh release delete "$RELEASE_VERSION" --yes || true
git tag -d "$RELEASE_VERSION" || true
git push --delete origin "$RELEASE_VERSION" || true

- name: Notify on failure
if: failure()
Expand Down
Loading