ci(npm-publish): add environment: production to publish job (fix OIDC ENEEDAUTH)#158
Open
jaysin586 wants to merge 1 commit into
Open
ci(npm-publish): add environment: production to publish job (fix OIDC ENEEDAUTH)#158jaysin586 wants to merge 1 commit into
jaysin586 wants to merge 1 commit into
Conversation
The npm trusted publisher for @humanspeak/svelte-diff-match-patch is scoped to the `production` environment, but the publish-github-packages job did not declare `environment: production`. Without it the OIDC token GitHub mints lacks the environment claim, so npm rejects the trusted-publish with ENEEDAUTH (run 28196102507). Every other repo in the fleet already sets this. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe npm publish workflow now sets the Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Publish run 28196102507 built the tarball, bumped the version, and created the release — then
Publishfailed with:Root cause
The npm Trusted Publisher for this package is configured for the
productionenvironment (Settings → Trusted Publisher:npm-publish.yml, envproduction). But thepublish-github-packagesjob was missingenvironment: production, so the OIDC token GitHub minted carried no matching environment claim and npm rejected the trusted publish.This was config drift — every other repo in the fleet already declares
environment: productionon its publish job; this is the only one that didn't.Fix
Add
environment: productionto thepublish-github-packagesjob (one line). No other change.Note
mainalready has aBump version to v0.1.3commit from the failed run (the README ecosystem footer landed fine). The failed run's cleanup removed the git tag + GitHub release but not the commit, so the next successful publish will land as0.1.4and0.1.3will be skipped on npm — harmless.🤖 Generated with Claude Code