Always exclude the prefix namespace

[hirasso]

Feature Request

The Problem

php-scoper currently scopes already-scoped packages again. Example:

// scoper.inc.php
return [
    'prefix' => 'RH\AdminUtils\Scoped',
];

The result in psr/log after the first run:

namespace RH\AdminUtils\Scoped\Psr\Log;

...after the second run:

namespace RH\AdminUtils\Scoped\RH\AdminUtils\Scoped\Psr\Log;

...after the third run:

namespace RH\AdminUtils\Scoped\RH\AdminUtils\Scoped\RH\AdminUtils\Scoped\Psr\Log;

...and so on. Currently one must add the prefix to exclude-namespaces as well to prevent this behavior:

return [
    'prefix' => 'RH\AdminUtils\Scoped',
    /** prevent double scoping */
    'exclude-namespaces' => ['RH\AdminUtils\Scoped'],
];

The solution

When a prefix is provided, php-scoper should automatically add that namespace to exclude-namespaces.

Considerations

This would of course not work when no custom prefix was provided and php-scoper chooses a random string. But it would be a nice quality-of-live improvement for the case where there is a prefix provided that doesn't change.

[theofidry]

PHP-Scoper does not re-apply the prefix generally, otherwise a good chunk the specifications would not work at all. Rather, I think the problem is that it does not handle the prefix being a namespace.

I am not sure how easy or hard it is to fix this, but if it is not possible, then I think it's better to fail to clarify its limitation rather than leaving this kind of surprise.