Skip to content

Commit 278bcfc

Browse files
committed
feat: update vector search parameters and improve documentation
- Changed `overquery_factor` to `ef_search` in multiple examples and tests for clarity and consistency. - Updated README and test documentation to reflect the increase in test coverage from 277 to 282 passed tests. - Enhanced error handling for `ef_search` values in vector index operations. - Improved comments and descriptions in the core and vector modules for better understanding of parameters.
1 parent 99a4a12 commit 278bcfc

9 files changed

Lines changed: 228 additions & 222 deletions

File tree

.github/workflows/test-python-examples.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ jobs:
367367
echo ""
368368
continue
369369
fi
370-
example_args="--backend arcadedb_sql --dataset stackoverflow-tiny --db-path $db_path --overquery-factors 1 --k 10 --query-limit 100 --query-runs 1 --query-order fixed --threads 1 --mem-limit 2g --run-label ci12_arcadedb_sql"
370+
example_args="--backend arcadedb_sql --dataset stackoverflow-tiny --db-path $db_path --ef-search-values 100 --k 10 --query-limit 100 --query-runs 1 --query-order fixed --threads 1 --mem-limit 2g --run-label ci12_arcadedb_sql"
371371
example_name="$example (vector search, arcadedb_sql backend, minimal)"
372372
timeout_duration=1200
373373
example_jvm_args=""

bindings/python/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
Native Python bindings for ArcadeDB - the multi-model database that supports Graph, Document, Key/Value, Search Engine, Time Series, and Vector models.
44

5-
**Status**: ✅ Production Ready | **Tests**: 277 Passed Across 27 Test Files | **Platforms**: 4 Supported
5+
**Status**: ✅ Production Ready | **Tests**: 282 Passed | **Platforms**: 4 Supported
66

77
---
88

@@ -92,7 +92,7 @@ Import: `import arcadedb_embedded as arcadedb`
9292

9393
## 🧪 Testing
9494

95-
**Status**: 277 passed across 27 test files
95+
**Status**: 282 passed
9696

9797
```bash
9898
# Run all tests

bindings/python/examples/11_vector_index_build.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1931,10 +1931,12 @@ def main() -> None:
19311931
args.run_label = args.run_label.strip().replace("/", "-").replace(" ", "_")
19321932
if args.jvm_heap_fraction <= 0 or args.jvm_heap_fraction > 1:
19331933
parser.error("--jvm-heap-fraction must be > 0 and <= 1")
1934-
args.qdrant_image = resolve_qdrant_image(args.qdrant_image)
1935-
args.milvus_compose_version = resolve_milvus_compose_version(
1936-
args.milvus_compose_version
1937-
)
1934+
if args.backend == "qdrant":
1935+
args.qdrant_image = resolve_qdrant_image(args.qdrant_image)
1936+
if args.backend == "milvus":
1937+
args.milvus_compose_version = resolve_milvus_compose_version(
1938+
args.milvus_compose_version
1939+
)
19381940
if args.backend == "pgvector" and args.docker_image == "python:3.12-slim":
19391941
args.docker_image = resolve_latest_pgvector_image()
19401942
configure_reproducibility(args.seed)

0 commit comments

Comments
 (0)