Skip to content

Commit 5a37680

Browse files
committed
fix: update edgeBidirectional setting and clean up example runs in tests
1 parent 2872c7d commit 5a37680

3 files changed

Lines changed: 15 additions & 37 deletions

File tree

bindings/python/examples/16_import_database_vs_transactional_graph_ingest.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -748,9 +748,7 @@ def run_import_database_graph_load(
748748
"typeIdUnique = true, "
749749
"edgeFromField = 'From', "
750750
"edgeToField = 'To', "
751-
# IMPORT DATABASE currently rejects edgeBidirectional = false here;
752-
# keep this true until ArcadeDB authors confirm intended behavior.
753-
"edgeBidirectional = true, "
751+
"edgeBidirectional = false, "
754752
f"commitEvery = {batch_size}, "
755753
f"parallel = {parallel}"
756754
),

bindings/python/examples/scripts/run_examples_01_16_minimal.py

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,6 @@ def build_examples(_examples_dir: Path) -> list[ExampleRun]:
8282
lambda _, __: [
8383
"--dataset",
8484
"movielens-small",
85-
"--parallel",
86-
"1",
87-
"--batch-size",
88-
"500",
8985
],
9086
),
9187
ExampleRun(
@@ -94,18 +90,25 @@ def build_examples(_examples_dir: Path) -> list[ExampleRun]:
9490
lambda _, __: [
9591
"--dataset",
9692
"movielens-small",
97-
"--batch-size",
98-
"500",
99-
"--parallel",
100-
"1",
101-
"--source-db",
102-
str(Path("my_test_databases") / "movielens_small_db"),
93+
"--method",
94+
"sql",
95+
"--no-async",
96+
"--export",
10397
],
10498
),
10599
ExampleRun(
106100
6,
107101
"06_vector_search_recommendations.py",
108-
lambda _, __: ["--source-db", str(small_graph_db), "--limit", "50"],
102+
lambda _, __: [
103+
"--source-db",
104+
str(small_graph_db),
105+
"--db-path",
106+
"my_test_databases/movielens_graph_small_db_vectors",
107+
"--import-jsonl",
108+
"exports/movielens_graph_small_db.jsonl.tgz",
109+
"--heap-size",
110+
"1g",
111+
],
109112
note="May download embedding model assets on first run.",
110113
),
111114
ExampleRun(

bindings/python/tests/test_cypher.py

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -203,29 +203,6 @@ def test_opencypher_aggregation(temp_db_path):
203203
)
204204
)
205205

206-
if not rows:
207-
# Temporary compatibility check: in some Java runtimes, mandatory
208-
# MATCH over WORKS_FOR returns no rows even though OPTIONAL MATCH
209-
# still sees the relationships. Keep this skip until upstream
210-
# confirms the intended behavior.
211-
optional_rows = [
212-
(record.get("name"), record.get("company"))
213-
for record in db.query(
214-
"opencypher",
215-
"MATCH (p:Person) "
216-
"OPTIONAL MATCH (p)-[:WORKS_FOR]->(c:Company) "
217-
"RETURN p.name as name, c.name as company ORDER BY name",
218-
)
219-
]
220-
if optional_rows[:2] == [("Alice", "Acme"), ("Bob", "Acme")]:
221-
pytest.skip(
222-
"OpenCypher mandatory MATCH over WORKS_FOR currently "
223-
"returns no rows in this Java runtime"
224-
)
225-
pytest.fail(
226-
"Expected OpenCypher aggregation row but query returned no rows"
227-
)
228-
229206
row = rows[0]
230207

231208
assert row.get("company") == "Acme"

0 commit comments

Comments
 (0)