ArcadeData#4000 fix(cypher): SET propagates to all aliases bound to the same node (ArcadeData#4004)

Author: robfrank

engine/src/main/java/com/arcadedb/query/opencypher/executor/steps/SetStep.java

@@ -20,12 +20,12 @@
 
 import com.arcadedb.database.Document;
 import com.arcadedb.database.MutableDocument;
+import com.arcadedb.database.RID;
 import com.arcadedb.exception.TimeoutException;
 import com.arcadedb.graph.Edge;
 import com.arcadedb.graph.MutableVertex;
 import com.arcadedb.graph.Vertex;
 import com.arcadedb.query.opencypher.Labels;
-import com.arcadedb.query.opencypher.ast.Expression;
 import com.arcadedb.query.opencypher.ast.SetClause;
 import com.arcadedb.query.opencypher.executor.CypherFunctionFactory;
 import com.arcadedb.query.opencypher.executor.ExpressionEvaluator;
@@ -178,8 +178,9 @@ private void applyPropertySet(final SetClause.SetItem item, final Result result)
       mutableDoc.set(item.getProperty(), value);
     }
     mutableDoc.save();
-
-    if (variableToUpdate != null)
+    propagateUpdateToSameNodeAliases(result, doc, mutableDoc);
+    // Fallback: ensure the named variable is updated even when doc has no identity yet
+    if (variableToUpdate != null && doc.getIdentity() == null)
       ((ResultInternal) result).setProperty(variableToUpdate, mutableDoc);
   }
 
@@ -210,7 +211,9 @@ private void applyReplaceMap(final SetClause.SetItem item, final Result result)
     }
 
     mutableDoc.save();
-    ((ResultInternal) result).setProperty(item.getVariable(), mutableDoc);
+    propagateUpdateToSameNodeAliases(result, doc, mutableDoc);
+    if (doc.getIdentity() == null)
+      ((ResultInternal) result).setProperty(item.getVariable(), mutableDoc);
   }
 
   @SuppressWarnings("unchecked")
@@ -235,7 +238,24 @@ private void applyMergeMap(final SetClause.SetItem item, final Result result) {
     }
 
     mutableDoc.save();
-    ((ResultInternal) result).setProperty(item.getVariable(), mutableDoc);
+    propagateUpdateToSameNodeAliases(result, doc, mutableDoc);
+    if (doc.getIdentity() == null)
+      ((ResultInternal) result).setProperty(item.getVariable(), mutableDoc);
+  }
+
+  /**
+   * After mutating a document, update every alias in the result row that points to the same node
+   * (identified by RID) so all aliases observe the new state within the same query.
+   */
+  private void propagateUpdateToSameNodeAliases(final Result result, final Document originalDoc, final Document updatedDoc) {
+    final RID originalRid = originalDoc.getIdentity();
+    if (originalRid == null)
+      return;
+    for (final String propName : result.getPropertyNames()) {
+      final Object prop = result.getProperty(propName);
+      if (prop instanceof Document other && other != updatedDoc && originalRid.equals(other.getIdentity()))
+        ((ResultInternal) result).setProperty(propName, updatedDoc);
+    }
   }
 
   private void applyLabels(final SetClause.SetItem item, final Result result) {
@@ -273,7 +293,7 @@ private void applyLabels(final SetClause.SetItem item, final Result result) {
     // Delete old vertex
     vertex.delete();
 
-    ((ResultInternal) result).setProperty(item.getVariable(), newVertex);
+    propagateUpdateToSameNodeAliases(result, vertex, newVertex);
   }
 
   private void validatePropertyValue(final Object value) {

engine/src/test/java/com/arcadedb/query/opencypher/OpenCypherSetTest.java

@@ -374,6 +374,57 @@ void setCaseSubclauseWithUnwind() {
     assertThat(vb.get("propB")).isNull();
   }
 
+  /**
+   * Issue #4000: SET through one alias must be visible through other aliases bound to the same node in the same row.
+   */
+  @Test
+  void setThroughOneAliasPropagatestoOtherAliasOnSameNode() {
+    database.transaction(() -> {
+      database.command("opencypher", "CREATE (:Person {name: 'Alice', age: 30}), (:Person {name: 'Bob', age: 25})");
+    });
+
+    final ResultSet result = database.command("opencypher",
+        "MATCH (n:Person {name: 'Alice'}), (m:Person {name: 'Alice'}) SET n.age = 35 RETURN n.age AS n_age, m.age AS m_age");
+
+    assertThat(result.hasNext()).isTrue();
+    final Result row = result.next();
+    assertThat(((Number) row.getProperty("n_age")).intValue()).isEqualTo(35);
+    assertThat(((Number) row.getProperty("m_age")).intValue()).isEqualTo(35);
+  }
+
+  /**
+   * Issue #4000: stronger reproducer — full node aliases bound via WITH+MATCH to the same node must reflect a SET on the other alias.
+   */
+  @Test
+  void setThroughOneAliasPropagatestoOtherAliasOnSameNodeFullNode() {
+    database.transaction(() -> {
+      database.command("opencypher", "CREATE (:Person {name: 'Alice', age: 30})");
+    });
+
+    final ResultSet result = database.command("opencypher",
+        "MATCH (n:Person {name: 'Alice'}) WITH n MATCH (m:Person {name: 'Alice'}) SET n.age = 35 RETURN n.age AS n_age, m.age AS m_age");
+
+    assertThat(result.hasNext()).isTrue();
+    final Result row = result.next();
+    assertThat(((Number) row.getProperty("n_age")).intValue()).isEqualTo(35);
+    assertThat(((Number) row.getProperty("m_age")).intValue()).isEqualTo(35);
+  }
+
+  @Test
+  void setLabelThroughOneAliasPropagatestoOtherAliasOnSameNode() {
+    database.transaction(() -> {
+      database.command("opencypher", "CREATE (:Person {name: 'Alice', age: 30})");
+    });
+
+    final ResultSet result = database.command("opencypher",
+        "MATCH (n:Person {name: 'Alice'}), (m:Person {name: 'Alice'}) SET n:Employee RETURN n.name AS n_name, m.name AS m_name");
+
+    assertThat(result.hasNext()).isTrue();
+    final Result row = result.next();
+    assertThat((String) row.getProperty("n_name")).isEqualTo("Alice");
+    assertThat((String) row.getProperty("m_name")).isEqualTo("Alice");
+  }
+
   @Test
   void setAfterCreate() {
     // CREATE and SET in same query