Skip to content

Commit 7a1a836

Browse files
committed
fix: Enable host tests for linux/arm64 on native ARM64 runner
Now that we use ubuntu-24.04-arm (native ARM64 runner), the host and wheel architectures match, so we can run tests directly on the host. Changes: - Removed 'if: matrix.platform != linux/arm64' conditions - Tests now run on all 5 platforms consistently - Removed special-case ARM64 summary message - All platforms show actual test results (not 'SKIPPED') Benefits: - Proper test verification on ARM64 hardware - Consistent test reporting across all platforms - No more confusing 'tested in Docker' messages
1 parent 70c67b3 commit 7a1a836

1 file changed

Lines changed: 6 additions & 18 deletions

File tree

.github/workflows/test-python-bindings.yml

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -180,17 +180,12 @@ jobs:
180180
# This package works without any external Java installation!
181181

182182
- name: Install wheel and test dependencies
183-
# Skip for linux/arm64: wheel contains ARM64 JRE but host is AMD64
184-
# (linux/arm64 is already tested in Docker during build via QEMU)
185-
if: matrix.platform != 'linux/arm64'
186183
shell: bash
187184
run: |
188185
cd bindings/python
189186
pip install test-install/*.whl pytest pytest-cov requests
190187
191188
- name: Run pytest on host
192-
# Skip for linux/arm64: already tested in Docker during build
193-
if: matrix.platform != 'linux/arm64'
194189
id: pytest
195190
shell: bash
196191
run: |
@@ -237,10 +232,8 @@ jobs:
237232
echo "## 🧪 Test Results: arcadedb-embedded (${{ matrix.platform }})" >> $GITHUB_STEP_SUMMARY
238233
echo "" >> $GITHUB_STEP_SUMMARY
239234
240-
# Check if pytest was skipped (e.g., linux/arm64)
241-
if [ "${{ steps.pytest.outcome }}" = "skipped" ]; then
242-
echo "⏭️ **Status**: SKIPPED (tested in Docker during build)" >> $GITHUB_STEP_SUMMARY
243-
elif [ "${{ steps.pytest.outcome }}" = "success" ]; then
235+
# Check test status
236+
if [ "${{ steps.pytest.outcome }}" = "success" ]; then
244237
echo "✅ **Status**: PASSED" >> $GITHUB_STEP_SUMMARY
245238
else
246239
echo "❌ **Status**: FAILED" >> $GITHUB_STEP_SUMMARY
@@ -250,15 +243,10 @@ jobs:
250243
echo "| Metric | Count |" >> $GITHUB_STEP_SUMMARY
251244
echo "|--------|-------|" >> $GITHUB_STEP_SUMMARY
252245
253-
# Show test results if pytest ran
254-
if [ "${{ steps.pytest.outcome }}" != "skipped" ]; then
255-
echo "| ✅ Passed | ${{ steps.pytest.outputs.passed || 'N/A' }} |" >> $GITHUB_STEP_SUMMARY
256-
echo "| ⏭️ Skipped | ${{ steps.pytest.outputs.skipped || 'N/A' }} |" >> $GITHUB_STEP_SUMMARY
257-
echo "| ❌ Failed | ${{ steps.pytest.outputs.failed || 'N/A' }} |" >> $GITHUB_STEP_SUMMARY
258-
else
259-
echo "| ℹ️ Host Tests | Skipped (ARM64 wheel on AMD64 host) |" >> $GITHUB_STEP_SUMMARY
260-
echo "| ✅ Docker Tests | Passed (verified during build) |" >> $GITHUB_STEP_SUMMARY
261-
fi
246+
# Show test results
247+
echo "| ✅ Passed | ${{ steps.pytest.outputs.passed || 'N/A' }} |" >> $GITHUB_STEP_SUMMARY
248+
echo "| ⏭️ Skipped | ${{ steps.pytest.outputs.skipped || 'N/A' }} |" >> $GITHUB_STEP_SUMMARY
249+
echo "| ❌ Failed | ${{ steps.pytest.outputs.failed || 'N/A' }} |" >> $GITHUB_STEP_SUMMARY
262250
echo "" >> $GITHUB_STEP_SUMMARY
263251
264252
echo "### 📦 Package Info:" >> $GITHUB_STEP_SUMMARY

0 commit comments

Comments
 (0)