Commit 98a012a
committed
fix: Use find instead of glob for Windows JAR exclusion compatibility
Windows bash (Git Bash/MSYS) doesn't expand globs the same way as Unix.
The pattern 'arcadedb-grpcw-*.jar' wasn't matching any files, resulting
in 0 JARs removed on Windows.
Change from:
for jar in "$JARS_DIR"/$pattern; do
To:
find "$JARS_DIR" -maxdepth 1 -name "$pattern" -type f
This uses find which is more portable across platforms and handles
Windows paths correctly.
Windows build log showed:
Processing pattern: arcadedb-grpcw-*.jar
✅ Removed 0 JAR(s)
✅ Package prepared (84 JARs + JRE)
After fix, should show:
Processing pattern: arcadedb-grpcw-*.jar
- Removed: arcadedb-grpcw-25.10.1-SNAPSHOT-shaded.jar
✅ Removed 1 JAR(s)
✅ Package prepared (83 JARs + JRE)
Expected impact:
- Windows AMD64: 192.5M → ~157M (saves ~35M)1 parent fd6dcee commit 98a012a
1 file changed
Lines changed: 3 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | | - | |
126 | | - | |
127 | | - | |
| 125 | + | |
| 126 | + | |
128 | 127 | | |
129 | 128 | | |
130 | 129 | | |
131 | 130 | | |
132 | | - | |
133 | | - | |
134 | 131 | | |
135 | | - | |
136 | | - | |
| 132 | + | |
137 | 133 | | |
138 | 134 | | |
139 | 135 | | |
| |||
0 commit comments