Conversation
🦋 Changeset detectedLatest commit: fede373 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
Expose the Tooltip Content positioning strategy prop so consumers can control Floating UI’s positioning behavior.
- Replace narrow Pick of FloatingLayerContentProps with a broad Omit to include strategy
- Wire the new strategy prop through tooltip-content.svelte to useFloatingContent
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/bits-ui/src/lib/bits/tooltip/types.ts | Broadens TooltipContentProps to include most FloatingLayerContentProps (to expose strategy). |
| packages/bits-ui/src/lib/bits/tooltip/components/tooltip-content.svelte | Adds strategy prop and forwards it to useFloatingContent. |
| .changeset/yummy-dolls-tell.md | Documents the patch change to expose strategy. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| | "dir" | ||
| | "customAnchor" | ||
| > & | ||
| Omit<FloatingLayerContentProps, "content" | "preventScroll"> & |
There was a problem hiding this comment.
Switching from a targeted Pick to a broad Omit exposes almost all FloatingLayerContentProps, not just strategy. This widens the public API surface for TooltipContent beyond the stated goal and risks conflicts with DismissibleLayerProps where keys overlap. Recommend reverting to Pick and explicitly adding 'strategy' to the allowlist to avoid unintended prop exposure.
| Omit<FloatingLayerContentProps, "content" | "preventScroll"> & | |
| Pick<FloatingLayerContentProps, "strategy"> & |
📦 Bundle Size Analysis📊 Modified Components
📋 Understanding Bundle Analysis
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
No description provided.