fix: don't propogate onclick event in calendar day handlers#1811
Closed
hmnd wants to merge 2 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: b3f5714 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Owner
|
I think this would be considered a breaking change, since others may be relying on this propagation to enable some other behavior. Would the following not work in your own implementation? <Calendar.Day onclick={(e) => e.stopPropagation()} /> |
Author
|
Sorry, just getting around to some date picker things now. Didn't realize that was an option at the time! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onclickis propogating through to the document in calendar day handlers. This was causing my custom implementation of a popover date picker to unexpectedly close. I found that when clicking a date outside the current month caused the displayed month to change, thedocument.onclickhandler in my popover could no longer see the original target of the click and was thus closed.