feat(Dialog): nested attributes & CSS vars#1841
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 174b2ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved Nested Dialogs Support
This PR adds improved support for nested dialogs and alert dialogs, providing data attributes and CSS custom properties that enable proper styling and behavior differentiation based on nesting depth and state.
Motivation
When nesting dialogs within other dialogs (e.g., opening a confirmation alert dialog from within a settings dialog), developers need ways to:
Changes
Data Attributes
Added to
Dialog.Content,Dialog.Overlay,AlertDialog.Content, andAlertDialog.Overlay:data-nested- Present when the dialog is nested within another dialog (any depth > 0)data-nested-open- Present when a dialog nested within this dialog is currently openCSS Variables
Added to
Dialog.Content,Dialog.Overlay,AlertDialog.Content, andAlertDialog.Overlay:--bits-dialog-depth- Zero-based depth of the current dialog (e.g.,0for root,1for first nested,2for second nested)--bits-dialog-nested-count- Number of dialogs currently nested and open within this dialog