Skip to content

Fix: Date typing improvements #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joe-herbert wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix: Date typing improvements #2046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e585713
Fix clearing year clears whole date
joe-herbert May 6, 2026
2313724
Fix padding 0s causing year completion
joe-herbert May 6, 2026
4294f17
Fix premature jump to next section
joe-herbert May 6, 2026
63153fa
Fix incorrect test
joe-herbert May 6, 2026
c1a93a2
Fix incorrect test
joe-herbert May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions packages/bits-ui/src/lib/bits/date-field/date-field.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ export class DateFieldRootState {
descriptionNode = $state<HTMLElement | null>(null);
validationNode = $state<HTMLElement | null>(null);
states = initSegmentStates();
#segmentClearedValue = false;
dayPeriodNode = $state<HTMLElement | null>(null);
rangeRoot: DateRangeFieldRootState | undefined = undefined;
name = $state("");
Expand Down Expand Up @@ -311,6 +312,10 @@ export class DateFieldRootState {

$effect(() => {
if (this.value.current === undefined) {
if (this.#segmentClearedValue) {
this.#segmentClearedValue = false;
return;
}
this.segmentValues = initializeSegmentValues(this.inferredGranularity);
}
});
Expand Down Expand Up @@ -680,6 +685,7 @@ export class DateFieldRootState {
})
);
} else {
this.#segmentClearedValue = true;
this.setValue(undefined);
this.segmentValues = newSegmentValues;
}
Expand Down Expand Up @@ -1253,7 +1259,7 @@ class DateFieldYearSegmentState extends BaseNumericSegmentState {
return mergedIntStr;
});

if (this.#pressedKeys.length === 4 || this.#pressedKeys.length === this.#backspaceCount) {
if (this.#pressedKeys.length === 4) {
moveToNext = true;
}

Expand All @@ -1274,15 +1280,16 @@ class DateFieldYearSegmentState extends BaseNumericSegmentState {
this.announcer.announce(null);
return null;
}
const str = prev.toString();
if (str.length === 1) {
// Use integer division to strip the last significant digit, so that
// zero-padded values like "0001" don't leave a confusing "000" remnant
// that causes subsequent typing to misinterpret the year.
const next = Math.floor(Number.parseInt(prev) / 10);
if (next === 0) {
this.announcer.announce(null);
return null;
}
const next = str.slice(0, -1);
this.announcer.announce(next);

return `${next}`;
return prependYearZeros(next);
});

if (moveToPrev) {
Expand Down
4 changes: 3 additions & 1 deletion tests/src/tests/date-field/date-field.browser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,9 @@ describe("date field", () => {
await userEvent.keyboard(kbd.BACKSPACE);
await expect.element(t.year).toHaveTextContent("009");
await userEvent.keyboard(kbd.BACKSPACE);
await expect.element(t.year).toHaveTextContent("00");
await expect.element(t.year).toHaveTextContent("yyyy");
await userEvent.keyboard(`{0}`);
await userEvent.keyboard(`{0}`);
await userEvent.keyboard(`{8}`);
await userEvent.keyboard(`{7}`);
await expect.element(t.year).toHaveTextContent("0087");
Expand Down
Loading