Update FpsDebugFrameCallback to allow set target FPS instead of hard coded one (facebook#41091)

Xin Chen · facebook-github-bot · commit c47bef6ae076 · 2023-10-19T22:59:44.000-07:00
Summary: Pull Request resolved: facebook#41091 Changelog: [Android][Internal] - Allow configurable target FPS for debug frame callback Reviewed By: javache Differential Revision: D49895740 fbshipit-source-id: 3818b14a929cd40c64b6ad2811d373ebff5c3dfc
diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/debug/FpsDebugFrameCallback.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/debug/FpsDebugFrameCallback.java
@@ -56,7 +56,7 @@ public FpsInfo(
     }
   }
 
-  private static final double EXPECTED_FRAME_TIME = 16.9;
+  private static final double DEFAULT_FPS = 60.0;
 
   private @Nullable Choreographer mChoreographer;
   private final ReactContext mReactContext;
@@ -70,6 +70,7 @@ public FpsInfo(
   private int m4PlusFrameStutters = 0;
   private int mNumFrameCallbacksWithBatchDispatches = 0;
   private boolean mIsRecordingFpsInfoAtEachFrame = false;
+  private double mTargetFps = DEFAULT_FPS;
   private @Nullable TreeMap<Long, FpsInfo> mTimeToFps;
 
   public FpsDebugFrameCallback(ReactContext reactContext) {
@@ -120,10 +121,15 @@ public void doFrame(long l) {
   }
 
   public void start() {
+    start(mTargetFps);
+  }
+
+  public void start(double targetFps) {
     mReactContext
         .getCatalystInstance()
         .addBridgeIdleDebugListener(mDidJSUpdateUiDuringFrameDetector);
     mUIManagerModule.setViewHierarchyUpdateDebugListener(mDidJSUpdateUiDuringFrameDetector);
+    mTargetFps = targetFps;
     UiThreadUtil.runOnUiThread(
         () -> {
           mChoreographer = Choreographer.getInstance();
@@ -173,7 +179,7 @@ public int getNumJSFrames() {
 
   public int getExpectedNumFrames() {
     double totalTimeMS = getTotalTimeMS();
-    int expectedFrames = (int) (totalTimeMS / EXPECTED_FRAME_TIME + 1);
+    int expectedFrames = (int) (mTargetFps * totalTimeMS / 1000 + 1);
     return expectedFrames;
   }
 
