Skip to content

Commit 4e663f2

Browse files
committed
[LOCAL] Remove stale frame event code from PerformanceTracer
The cherry-pick of early commits (ce60f27, 85905ad) introduced frame event types and methods to PerformanceTracer that were subsequently removed on main as part of the backout/re-land cycle. Since we skipped the backout commits (the originals weren't on the branch), these stale references remained. Frame timing is now handled entirely through HostTarget and TraceEventGenerator, so these PerformanceTracer methods and visitor lambdas are dead code that fails to compile.
1 parent 6008daf commit 4e663f2

File tree

1 file changed

+0
-101
lines changed

1 file changed

+0
-101
lines changed

packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp

Lines changed: 0 additions & 101 deletions
Original file line numberDiff line numberDiff line change
@@ -362,50 +362,6 @@ void PerformanceTracer::reportResourceFinish(
362362
});
363363
}
364364

365-
void PerformanceTracer::setLayerTreeId(std::string frame, int layerTreeId) {
366-
enqueueEvent(
367-
PerformanceTracerSetLayerTreeIdEvent{
368-
.frame = std::move(frame),
369-
.layerTreeId = layerTreeId,
370-
.start = HighResTimeStamp::now(),
371-
.threadId = getCurrentThreadId(),
372-
});
373-
}
374-
375-
void PerformanceTracer::reportFrameTiming(
376-
int frameSeqId,
377-
HighResTimeStamp start,
378-
HighResTimeStamp end) {
379-
if (!tracingAtomic_) {
380-
return;
381-
}
382-
383-
std::lock_guard<std::mutex> lock(mutex_);
384-
if (!tracingAtomic_) {
385-
return;
386-
}
387-
388-
ThreadId threadId = getCurrentThreadId();
389-
enqueueEvent(
390-
PerformanceTracerFrameBeginDrawEvent{
391-
.frameSeqId = frameSeqId,
392-
.start = start,
393-
.threadId = threadId,
394-
});
395-
enqueueEvent(
396-
PerformanceTracerFrameCommitEvent{
397-
.frameSeqId = frameSeqId,
398-
.start = start,
399-
.threadId = threadId,
400-
});
401-
enqueueEvent(
402-
PerformanceTracerFrameDrawEvent{
403-
.frameSeqId = frameSeqId,
404-
.start = end,
405-
.threadId = threadId,
406-
});
407-
}
408-
409365
/* static */ TraceEvent PerformanceTracer::constructRuntimeProfileTraceEvent(
410366
RuntimeProfileId profileId,
411367
ProcessId processId,
@@ -783,63 +739,6 @@ void PerformanceTracer::enqueueTraceEventsFromPerformanceTracerEvent(
783739
.args = folly::dynamic::object("data", std::move(data)),
784740
});
785741
},
786-
[&](PerformanceTracerSetLayerTreeIdEvent&& event) {
787-
events.emplace_back(
788-
TraceEventGenerator::createSetLayerTreeIdEvent(
789-
std::move(event.frame),
790-
event.layerTreeId,
791-
processId_,
792-
event.threadId,
793-
event.start));
794-
},
795-
[&](PerformanceTracerFrameBeginDrawEvent&& event) {
796-
folly::dynamic data = folly::dynamic::object(
797-
"frameSeqId", event.frameSeqId)("layerTreeId", 1);
798-
799-
events.emplace_back(
800-
TraceEvent{
801-
.name = "BeginFrame",
802-
.cat = {Category::Timeline},
803-
.ph = 'I',
804-
.ts = event.start,
805-
.pid = processId_,
806-
.s = 't',
807-
.tid = event.threadId,
808-
.args = std::move(data),
809-
});
810-
},
811-
[&](PerformanceTracerFrameCommitEvent&& event) {
812-
folly::dynamic data = folly::dynamic::object(
813-
"frameSeqId", event.frameSeqId)("layerTreeId", 1);
814-
815-
events.emplace_back(
816-
TraceEvent{
817-
.name = "Commit",
818-
.cat = {Category::Timeline},
819-
.ph = 'I',
820-
.ts = event.start,
821-
.pid = processId_,
822-
.s = 't',
823-
.tid = event.threadId,
824-
.args = std::move(data),
825-
});
826-
},
827-
[&](PerformanceTracerFrameDrawEvent&& event) {
828-
folly::dynamic data = folly::dynamic::object(
829-
"frameSeqId", event.frameSeqId)("layerTreeId", 1);
830-
831-
events.emplace_back(
832-
TraceEvent{
833-
.name = "DrawFrame",
834-
.cat = {Category::Timeline},
835-
.ph = 'I',
836-
.ts = event.start,
837-
.pid = processId_,
838-
.s = 't',
839-
.tid = event.threadId,
840-
.args = std::move(data),
841-
});
842-
},
843742
},
844743
std::move(event));
845744
}

0 commit comments

Comments
 (0)