Auto-reconnect PackagerConnection to Metro dev server (facebook#56625)

Summary:
Pull Request resolved: facebook#56625

When MWA starts before Metro is running, PackagerConnection's WebSocket connection to Metro's `/message` endpoint silently fails with no retry. The developer must restart MWA after starting Metro to get HMR working.

This diff adds reconnection logic to PackagerConnection so it automatically retries when Metro becomes available. On initial connect failure or WebSocket disconnect, PackagerConnection schedules a retry after 5 seconds using the existing `WebSocketClientFactory` to create a fresh client. On successful reconnect, it fires `liveReloadCallback_()` which triggers `FoxReactHost::reloadReactInstance()` to load the bundle from Metro and set up HMR.

The reconnection is event-driven: each retry is a short-lived thread that sleeps 5 seconds then calls `attemptConnection()`. The connect callback handles success/failure — no long-lived polling thread. The `active_` flag is set to false in the destructor to stop retries during shutdown.

Combined with D97570592's push-based route invalidation, this completes the dev loop: Metro can start at any time, PackagerConnection auto-reconnects, HMR keeps the bundle fresh, and route changes propagate automatically.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D97823787

fbshipit-source-id: b195b8f67713e690279f4f96fb95264b125630c4

Author: javache

packages/react-native/ReactCxxPlatform/react/devsupport/PackagerConnection.cpp

@@ -9,22 +9,40 @@
 
 #include <glog/logging.h>
 #include <nlohmann/json.hpp>
-#include <utility>
 
 namespace facebook::react {
 
 PackagerConnection::PackagerConnection(
-    const WebSocketClientFactory& webSocketClientFactory,
-    const std::string& packagerConnectionUrl,
+    WebSocketClientFactory webSocketClientFactory,
+    std::string packagerConnectionUrl,
     LiveReloadCallback&& liveReloadCallback,
     ShowDevMenuCallback&& showDevMenuCallback)
-    : liveReloadCallback_(std::move(liveReloadCallback)),
+    : webSocketClientFactory_(std::move(webSocketClientFactory)),
+      packagerConnectionUrl_(std::move(packagerConnectionUrl)),
+      liveReloadCallback_(std::move(liveReloadCallback)),
       showDevMenuCallback_(std::move(showDevMenuCallback)) {
-  websocket_ = webSocketClientFactory();
+  attemptConnection();
+}
+
+PackagerConnection::~PackagerConnection() noexcept {
+  reconnectThread_.quit();
+  if (websocket_) {
+    websocket_->setOnClosedCallback(nullptr);
+    websocket_->setOnMessageCallback(nullptr);
+    websocket_->close("PackagerConnection destroyed");
+  }
+}
+
+void PackagerConnection::attemptConnection() {
+  if (websocket_) {
+    websocket_->setOnClosedCallback(nullptr);
+    websocket_->close("reconnecting");
+  }
+  websocket_ = webSocketClientFactory_();
   websocket_->setOnMessageCallback([this](const std::string& message) {
     LOG(INFO) << "Received message from packager: " << message;
-    auto json = nlohmann::json::parse(message);
-    if (json.is_null() || json["version"] != 2) {
+    auto json = nlohmann::json::parse(message, nullptr, false);
+    if (json.is_discarded() || json.is_null() || json["version"] != 2) {
       return;
     }
     auto method = json["method"];
@@ -34,11 +52,38 @@ PackagerConnection::PackagerConnection(
       showDevMenuCallback_();
     }
   });
-  websocket_->connect(packagerConnectionUrl);
+  websocket_->setOnClosedCallback([this](const std::string& reason) {
+    LOG(INFO) << "PackagerConnection closed: " << reason;
+    scheduleReconnect();
+  });
+  websocket_->connect(
+      packagerConnectionUrl_,
+      [this](bool success, const std::string& /*error*/) {
+        if (success) {
+          if (!isInitialConnection_) {
+            LOG(INFO)
+                << "PackagerConnection connected to Metro - triggering live reload";
+            liveReloadCallback_();
+          } else {
+            LOG(INFO) << "PackagerConnection connected to Metro";
+          }
+        } else {
+          scheduleReconnect();
+        }
+        isInitialConnection_ = false;
+      });
 }
 
-PackagerConnection::~PackagerConnection() noexcept {
-  websocket_->close("PackagerConnection destroyed");
+void PackagerConnection::scheduleReconnect() {
+  if (reconnectPending_.exchange(true)) {
+    return;
+  }
+  reconnectThread_.runAsync(
+      [this]() {
+        reconnectPending_ = false;
+        attemptConnection();
+      },
+      std::chrono::milliseconds(5000));
 }
 
 } // namespace facebook::react

packages/react-native/ReactCxxPlatform/react/devsupport/PackagerConnection.h

@@ -8,6 +8,8 @@
 #pragma once
 
 #include <react/http/IWebSocketClient.h>
+#include <react/threading/TaskDispatchThread.h>
+#include <atomic>
 #include <functional>
 #include <memory>
 #include <string>
@@ -20,8 +22,8 @@ class PackagerConnection {
 
  public:
   PackagerConnection(
-      const WebSocketClientFactory &webSocketClientFactory,
-      const std::string &packagerConnectionUrl,
+      WebSocketClientFactory webSocketClientFactory,
+      std::string packagerConnectionUrl,
       LiveReloadCallback &&liveReloadCallback,
       ShowDevMenuCallback &&showDevMenuCallback);
   ~PackagerConnection() noexcept;
@@ -31,9 +33,17 @@ class PackagerConnection {
   PackagerConnection &operator=(PackagerConnection &&other) = delete;
 
  private:
+  void attemptConnection();
+  void scheduleReconnect();
+
+  const WebSocketClientFactory webSocketClientFactory_;
+  const std::string packagerConnectionUrl_;
   const LiveReloadCallback liveReloadCallback_;
   const ShowDevMenuCallback showDevMenuCallback_;
   std::unique_ptr<IWebSocketClient> websocket_;
+  std::atomic<bool> isInitialConnection_{true};
+  std::atomic<bool> reconnectPending_{false};
+  TaskDispatchThread reconnectThread_{"PackagerReconnect"};
 };
 
 } // namespace facebook::react

packages/react-native/ReactCxxPlatform/react/runtime/ReactHost.cpp

@@ -398,7 +398,6 @@ bool ReactHost::loadScriptFromDevServer() {
     devServerHelper_->setupHMRClient();
     return true;
   } catch (...) {
-    devServerHelper_->setSourcePath("");
     LOG(WARNING)
         << "Unable to download JS bundle from Metro, falling back to prebuilt JS bundle. "
         << "To start Metro, run in command line: 'cd ~/fbsource/xplat/js && js1 run'";