Skip to content

Commit 67ae017

Browse files
authored
Update CMakeLists.txt
1 parent c00744a commit 67ae017

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

CMakeLists.txt

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,6 @@ elseif(TEST_HURCHALLA_LIBS)
4646
endif()
4747

4848

49-
50-
# TODO: I'm not sure whether these lines provide any benefit:
51-
# --------------------
5249
if(NOT DEFINED CMAKE_ARCHIVE_OUTPUT_DIRECTORY)
5350
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR})
5451
endif()
@@ -60,7 +57,6 @@ if(NOT DEFINED CMAKE_RUNTIME_OUTPUT_DIRECTORY)
6057
endif()
6158

6259

63-
6460
add_library(hurchalla_modular_arithmetic INTERFACE)
6561

6662

@@ -76,12 +72,12 @@ target_link_libraries(hurchalla_modular_arithmetic
7672

7773

7874

79-
# TODO: The following is a guess at a good way to install target include
80-
# directories. It assumes that the build step from the subdirectories
75+
# TODO: The following may be overly simple, but works so far to install target
76+
# include directories. It assumes that the build step from the subdirectories
8177
# montgomery_arithmetic and modular_arithmetic (which have build phase
8278
# target_include_directories commands) provides the information to cmake which
83-
# cmake then uses in the install phase target_include_directories below. I've
84-
# done very little testing of cmake install so far though...
79+
# cmake then uses in the install phase target_include_directories below. This
80+
# has worked for the basic cmake install tests I've done so far...
8581
# ---------------------
8682
target_include_directories(hurchalla_modular_arithmetic
8783
INTERFACE $<INSTALL_INTERFACE:include>)

0 commit comments

Comments
 (0)