test(#233): establish web-package test harness + characterization tests#238
Open
husamql3 wants to merge 1 commit into
Open
test(#233): establish web-package test harness + characterization tests#238husamql3 wants to merge 1 commit into
husamql3 wants to merge 1 commit into
Conversation
- Add vitest, @testing-library/{react,jest-dom,user-event}, and happy-dom
devDependencies plus `test`/`test:watch` scripts to the web package so the
previously-orphaned test file can run and CI picks the web suite up.
- Create vitest.config.ts (happy-dom env, `@`/`@db-studio/shared` aliases) and
tests/setup.ts (Testing Library matchers + afterEach cleanup).
- Extend parse-bulk-data.test.ts with JSON/CSV edge cases (malformed JSON,
quoted delimiters, semicolon detection, leading-zero preservation,
header-only input, blank-line handling).
- Add format-cell-value.test.ts (nullish, primitives, object serialization,
circular-ref fallback) and overlay.store.test.ts (open/close/toggle/query
state transitions).
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle Size
File breakdown
File breakdown |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/web— the package had novitestdependency and notestscript, so its single existing test could not run. Adds the devDependencies,vitest.config.ts(happy-dom env +@alias),tests/setup.ts, andtest/test:watchscripts. Rootbun run testnow runs the web suite alongside the server suite via Turbo (no CI change needed).bun.lock—bun installreconciled pre-existing manifest/lock drift (portless, vite,@tanstack/*) beyond the four test deps. Not arbitrary (the manifests already declared those ranges), but if you prefer a lockfile-clean PR, resetbun.lockto base and re-add only the test devDependencies.Testing
cd packages/web && bun run test→ 54 tests pass across 3 filesbun run test(root) → server (997) + web (54) all passbun run typecheck,bun run format→ passCloses #233
Glossary