Fix issue if user ID is a Ulid

Author: TomHart

CHANGELOG.md

@@ -1,5 +1,8 @@
 Changelog
 =========
+## 2.4.1
+* Bugfix: Prevent error in `EntityUserProvider::refreshUser` when `$userId` is a `Ulid`
+
 ## 2.4.0 (2025-05-29)
 * Added PHP 8.4 test coverage,
 * Added: LinkedIn OpenID resource owner,

composer.json

@@ -102,7 +102,8 @@
         "symfony/form":                   "^6.4 || ^7.4 || ^8.0",
         "symfony/http-client":            "^6.4 || ^7.4 || ^8.0",
         "symfony/routing":                "^6.4 || ^7.4 || ^8.0",
-        "symfony/twig-bundle":            "^6.4 || ^7.4 || ^8.0"
+        "symfony/twig-bundle":            "^6.4 || ^7.4 || ^8.0",
+        "symfony/uid":                    "^6.4 || ^7.4 || ^8.0"
     },
 
     "require-dev": {

src/Security/Core/User/EntityUserProvider.php

@@ -94,7 +94,7 @@ public function refreshUser(UserInterface $user): UserInterface
         $username = $user->getUserIdentifier();
 
         if (null === $user = $this->findUser([$identifier => $userId])) {
-            throw $this->createUserNotFoundException($username, \sprintf('User with ID "%d" could not be reloaded.', $userId));
+            throw $this->createUserNotFoundException($username, \sprintf('User with ID "%s" could not be reloaded.', $userId));
         }
 
         return $user;

tests/Fixtures/UlidUser.php

@@ -0,0 +1,40 @@
+<?php
+
+/*
+ * This file is part of the HWIOAuthBundle package.
+ *
+ * (c) Hardware Info <opensource@hardware.info>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace HWI\Bundle\OAuthBundle\Tests\Fixtures;
+
+use Symfony\Component\Security\Core\User\UserInterface;
+use Symfony\Component\Uid\Ulid;
+
+final class UlidUser implements UserInterface
+{
+    private Ulid $ulid;
+
+    public function __construct()
+    {
+        $this->ulid = new Ulid('01KGW7EGJX0SHRF6RZ5YYFBR40');
+    }
+
+    public function getId(): Ulid
+    {
+        return $this->ulid;
+    }
+
+    public function getRoles(): array
+    {
+        return [];
+    }
+
+    public function getUserIdentifier(): string
+    {
+        return 'abc';
+    }
+}

tests/Security/Core/User/EntityUserProviderTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the HWIOAuthBundle package.
  *
@@ -15,9 +17,11 @@
 use Doctrine\Persistence\ManagerRegistry;
 use Doctrine\Persistence\ObjectManager;
 use Doctrine\Persistence\ObjectRepository;
+use ErrorException;
 use HWI\Bundle\OAuthBundle\OAuth\ResourceOwnerInterface;
 use HWI\Bundle\OAuthBundle\OAuth\Response\UserResponseInterface;
 use HWI\Bundle\OAuthBundle\Security\Core\User\EntityUserProvider;
+use HWI\Bundle\OAuthBundle\Tests\Fixtures\UlidUser;
 use HWI\Bundle\OAuthBundle\Tests\Fixtures\User;
 use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\IgnoreDeprecations;
@@ -184,4 +188,33 @@ private function assertUserNotFoundException(): void
     {
         $this->expectException(UserNotFoundException::class);
     }
+
+    public function testRefreshUserWorksWithUlid(): void
+    {
+        // Simulate `framework.php_errors.throw: true`
+        set_error_handler(static function (
+            int $severity,
+            string $message,
+            string $file,
+            int $line
+        ): never {
+            throw new ErrorException($message, 0, $severity, $file, $line);
+        });
+
+        try {
+            $this->assertUserNotFoundException();
+            $this->expectExceptionMessage('User with ID "01KGW7EGJX0SHRF6RZ5YYFBR40" could not be reloaded.');
+
+            $provider = new EntityUserProvider(
+                $this->createManagerRegistryMock(),
+                UlidUser::class,
+                []
+            );
+
+            $provider->refreshUser(new UlidUser());
+        } finally {
+            restore_error_handler();
+        }
+    }
+
 }