Fix issue if user ID is a Ulid#2065
Closed
TomHart wants to merge 1 commit intohwi:masterfrom
Closed
Conversation
TomHart
force-pushed
the
allow_ulid
branch
2 times, most recently
from
4316604 to
24679d7
Compare
stloyd
reviewed
Feb 7, 2026
Remove dep Change ID dep
Author
|
I've updated this with master now, hopefully all the tests still pass 🤞 |
|
Message to comment on stale PRs. If none provided, will not mark PRs stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed an issue in my application, where upon failing to refresh the user an error is thrown. Digging into it it appears to be the combination of
framework.php_errors.throw: true(treat warnings as errors) and the conversion of aUlidtoint.This simply changes the format string to allow
Ulid::__toStringto be used.