Fix hydrasdr_set_samplerate() to support Firmware alt conf and fix few minor warnings

Author: bvernoux

hydrasdr-tools/src/hydrasdr_r82x.c

@@ -172,7 +172,7 @@ uint8_t conf_r82x[] =
 
 int configure_registers(struct hydrasdr_device* device)
 {
-	int i, j;
+	size_t i, j;
 	uint8_t register_number;
 	uint8_t register_value;
 	int result = HYDRASDR_SUCCESS;

libhydrasdr/src/hydrasdr.c

@@ -85,7 +85,7 @@ static const hydrasdr_device_entry_t hydrasdr_device_registry[] = {
  */
 static const hydrasdr_device_entry_t* find_device_by_vid_pid(uint16_t vid, uint16_t pid)
 {
-	for (int i = 0; i < HYDRASDR_DEVICE_REGISTRY_COUNT; i++) {
+	for (size_t i = 0; i < HYDRASDR_DEVICE_REGISTRY_COUNT; i++) {
 		if (hydrasdr_device_registry[i].vid == vid &&
 		    hydrasdr_device_registry[i].pid == pid) {
 			return &hydrasdr_device_registry[i];
@@ -100,7 +100,7 @@ static const hydrasdr_device_entry_t* find_device_by_vid_pid(uint16_t vid, uint1
  */
 static const hydrasdr_device_entry_t* find_device_by_board_id(enum hydrasdr_board_id board_id)
 {
-	for (int i = 0; i < HYDRASDR_DEVICE_REGISTRY_COUNT; i++) {
+	for (size_t i = 0; i < HYDRASDR_DEVICE_REGISTRY_COUNT; i++) {
 		if (hydrasdr_device_registry[i].board_id == board_id) {
 			return &hydrasdr_device_registry[i];
 		}

libhydrasdr/src/hydrasdr_shared.c

@@ -990,6 +990,7 @@ static int hydrasdr_create_io_threads(hydrasdr_streaming_t* stream, hydrasdr_sam
 {
 	int result;
 	pthread_attr_t attr;
+	(void)callback;
 
 	/* Note: streaming flag is already set by hydrasdr_start_streaming()
 	 * before USB transfers are submitted (to avoid race condition).
@@ -1505,15 +1506,19 @@ static int rate_compare_desc(const void *a, const void *b)
  */
 int hydrasdr_generic_build_virtual_samplerates(struct hydrasdr_device* dev)
 {
-	hydrasdr_streaming_t* stream = (hydrasdr_streaming_t*)dev->private_data;
+	hydrasdr_streaming_t* stream;
 	uint32_t *temp_rates;
 	uint32_t temp_count = 0;
 	uint32_t max_rates;
 	uint32_t i, d, j;
 	uint32_t unique_count;
 	static const uint32_t dec_factors[] = {1, 2, 4, 8, 16, 32, 64};
 
-	if (!dev || !stream) {
+	if (!dev) {
+		return HYDRASDR_ERROR_INVALID_PARAM;
+	}
+	stream = (hydrasdr_streaming_t*)dev->private_data;
+	if (!stream) {
 		return HYDRASDR_ERROR_INVALID_PARAM;
 	}
 
@@ -1896,7 +1901,9 @@ int hydrasdr_generic_set_samplerate(struct hydrasdr_device* dev, uint32_t sample
 		}
 
 		if (!found) {
-			return HYDRASDR_ERROR_INVALID_PARAM;
+			/* Let firmware decide (alt config rates) */
+			hw_rate = samplerate;
+			decimation = 1;
 		}
 	}