migrate: fix HUSTOJ existed problems by bhscer · Pull Request #1009 · hydro-dev/Hydro

bhscer · 2025-07-03T01:13:12Z

Fix:

Contest is using db's password as password
TestRun submissions should be ignored, or will make hydro's submission list have unknown problem
Contest's problem's order is incorrect

New feature:

Show progress when migrating user and contest

Summary by CodeRabbit

Enhancements
- Improved progress reporting during user, problem, contest, and solution imports with regular status updates.
- User import now accurately tracks the number of accepted problems per user.
- Import process correctly handles contest passwords and excludes test runs not linked to valid problems.
Bug Fixes
- Fixed contest password assignment.
- Skipped solution imports for test runs without valid problem associations.

coderabbitai · 2025-07-03T01:13:19Z

Walkthrough

The migration script in packages/migrate/scripts/hustoj.ts was updated to enhance progress reporting and data filtering during the import of users, problems, contests, and solutions. Several for...of loops were replaced with indexed for loops to allow periodic progress updates at defined intervals. The contest password assignment was corrected to use the proper source variable. Solution import queries were modified to exclude solutions with problem_id=0, filtering out test runs. No changes were made to exported function signatures or the core data transformation logic.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/migrate/scripts/hustoj.ts

Oops! Something went wrong! :(

ESLint: 9.30.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@hydrooj/eslint-config' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:202:49)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0af69c0 and 4315ee9.

📒 Files selected for processing (1)

packages/migrate/scripts/hustoj.ts (6 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/migrate/scripts/hustoj.ts

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

♻️ Duplicate comments (2)

packages/migrate/scripts/hustoj.ts (2)

240-245: Same off-by-one in problem progress output.

pageId % 10 === 0 logs before any page is processed. Use (pageId + 1) % 10 === 0.

293-297: Ditto for contest progress output.

Adjust the modulus check to avoid the 0th-iteration log.

🧹 Nitpick comments (2)

packages/migrate/scripts/hustoj.ts (2)
142-146: Off-by-one in progress reporting condition.

uidx % 100 === 0 fires on the very first iteration (uidx = 0) and prints “1 / N (1 %)”.
Use (uidx + 1) % 100 === 0 (or start the counter at 1) to avoid the premature message:
-if (uidx % 100 === 0) {
+if ((uidx + 1) % 100 === 0) {
Apply the same fix to the problem/contest/record loops below.

323-328: Mixed number / BigInt arithmetic – define step as BigInt for clarity.

step is a number, but is combined with BigInt in expressions (BigInt(step), template literals, etc.).
Define once:
-const step = 50;
+const step = 50n;            // BigInt
and drop the repeated casts. This removes implicit conversions and keeps the math type-safe.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 10f1517 and 57a1ecc.

📒 Files selected for processing (1)

packages/migrate/scripts/hustoj.ts (6 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

packages/migrate/scripts/hustoj.ts (1)

packages/hydrooj/src/script/problemStat.ts (1)

udoc (9-52)

🔇 Additional comments (1)

packages/migrate/scripts/hustoj.ts (1)

137-139: Existing users never get nAccept/nSubmit updated.

When a duplicate user is detected earlier the branch skips this setUserInDomain call, leaving their stats at whatever default existed.
If the objective is to reflect accurate acceptance counts for all users, update nAccept & nSubmit in the duplicate branch as well.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (2)

packages/migrate/scripts/hustoj.ts (2)
142-147: Progress log fires on the very first item

uidx % 100 === 0 (and similar checks below) logs at index 0, 100, 200…
If you only want every full 100 processed, use (uidx + 1) % 100 === 0 or start loop counter at 1.

322-327: BigInt / Number mixing in LIMIT clause

LIMIT ${pageId * BigInt(step)}, ${step} concatenates a BigInt and a Number.
While string interpolation works, JS forbids arithmetic mixing—this is safe here but brittle. Consider:
const offset = Number(pageId) * step;
const limit  = step;
...
LIMIT ${offset}, ${limit}
Keeps types consistent and avoids accidental BigInt leaks elsewhere.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 10f1517 and 57a1ecc.

📒 Files selected for processing (1)

packages/migrate/scripts/hustoj.ts (6 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

packages/migrate/scripts/hustoj.ts (1)

packages/hydrooj/src/script/problemStat.ts (1)

udoc (9-52)

🔇 Additional comments (1)

packages/migrate/scripts/hustoj.ts (1)

285-288: Contest password is stored verbatim

{ _code: tdoc.password } persists the raw password.
Confirm that Hydro’s ContestModel hashes/encodes this field on add; otherwise store a hash to avoid leaking plain credentials in the DB backup.

undefined-moe · 2025-07-03T10:24:27Z

                school: udoc.school || '',
                nSubmit: udoc.submit,
-                nAccept: 0,
+                nAccept: userAcMap[udoc.user_id] || 0,


This can be re-calculated by daily task, so there's no need to ensure it's correct

migrate: fix HUSTOJ existed problems

f94763d

fix spell mistake

57a1ecc

coderabbitai Bot reviewed Jul 3, 2025

View reviewed changes

Comment thread packages/migrate/scripts/hustoj.ts Outdated

coderabbitai Bot reviewed Jul 3, 2025

View reviewed changes

Comment thread packages/migrate/scripts/hustoj.ts Outdated

migrate: use a faster way to get user solved problem count

946e185

undefined-moe reviewed Jul 3, 2025

View reviewed changes

bhscer added 2 commits July 3, 2025 18:33

remove user accept count query

0af69c0

migrate: fix HUSTOJ contest problem have wrong order

4315ee9

undefined-moe approved these changes Jul 4, 2025

View reviewed changes

undefined-moe merged commit d7b41fd into hydro-dev:master Jul 4, 2025
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

migrate: fix HUSTOJ existed problems#1009

migrate: fix HUSTOJ existed problems#1009
undefined-moe merged 5 commits into
hydro-dev:masterfrom
bhscer:hustoj-migrate-fix

bhscer commented Jul 3, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 3, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

undefined-moe Jul 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

bhscer commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

undefined-moe Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bhscer commented Jul 3, 2025 •

edited

Loading

coderabbitai Bot commented Jul 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)