CodeRabbit Generated Unit Tests: Add zh_TW locale validation test suite by coderabbitai[bot] · Pull Request #1101 · hydro-dev/Hydro

coderabbitai · 2025-12-21T04:29:22Z

Unit test generation was requested by @Bryan0324.

Add missing zh_TW translations for error messages and UI strings #1099 (comment)

The following files were modified:

LOCALE_TESTS_SUMMARY.md
TEST_IMPLEMENTATION_REPORT.md
packages/hydrooj/tests/locale.spec.ts
run-locale-tests.js
test/README_LOCALE_TESTS.md
test/locale.spec.js

coderabbitai · 2025-12-21T04:29:28Z

Important

Review skipped

CodeRabbit bot authored PR detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

hydro-dev-bot · 2025-12-21T04:29:30Z

Thank you for your submission, we really appreciate it.
Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Comment I have read the CLA Document and I hereby sign the CLA below to sign it.

+let expect;
+try {
+    const chai = require('chai');
+    expect = chai.expect;


In general, the fix is to ensure that the value assigned to expect is actually used, or remove the unused assignment if it is truly unnecessary. Here, we want to preserve functionality: expose expect to the tests. The best way is to explicitly attach the chosen assertion function to a property that the test files will use, such as global.expect, and make that assignment the clear consumer of the expect variable.

Concretely, in run-locale-tests.js, after determining expect in both the try and catch branches, we should assign it to global.expect. To avoid duplication and keep behavior unchanged, we can leave the existing expect = ... lines as they are, and then, after the try/catch block, add a single line global.expect = expect;. This uses the expect local variable, satisfying CodeQL, and exports it in the expected global location for the tests required on line 68. No new imports or helper methods are needed; we only add one line after the block.

+    expect = (val) => ({
+        to: {
+            be: {
+                an: (type) => {
+                    if (typeof val !== type) throw new Error(`Expected ${type}, got ${typeof val}`);
+                },
+                a: (type) => {
+                    if (typeof val !== type) throw new Error(`Expected ${type}, got ${typeof val}`);
+                },
+                true: () => {
+                    if (val !== true) throw new Error(`Expected true, got ${val}`);
+                },
+                empty: () => {
+                    if (val.length !== 0) throw new Error(`Expected empty, got length ${val.length}`);
+                },
+                greaterThan: (n) => {
+                    if (val <= n) throw new Error(`Expected > ${n}, got ${val}`);
+                }
+            },
+            have: {
+                length: {
+                    greaterThan: (n) => {
+                        if (val.length <= n) throw new Error(`Expected length > ${n}, got ${val.length}`);
+                    }
+                }
+            },
+            equal: (expected) => {
+                if (val !== expected) throw new Error(`Expected ${expected}, got ${val}`);
+            },
+            not: {
+                throw: () => {
+                    try {
+                        val();
+                    } catch (e) {
+                        throw new Error(`Expected not to throw, but threw: ${e.message}`);
+                    }
+                },
+                include: (str) => {
+                    if (val.includes(str)) throw new Error(`Expected not to include ${str}`);
+                },
+                be: {
+                    null: () => {
+                        if (val === null) throw new Error('Expected not to be null');
+                    }
+                }
+            },
+            match: (regex) => {
+                if (!regex.test(val)) throw new Error(`Expected to match ${regex}`);
+            }
+        }
+    });


To fix this, the expect we define in the catch block must be made accessible to the tests that require('./packages/hydrooj/tests/locale.spec.ts'). The simplest, non‑intrusive way is to assign the same function to global.expect in addition to the local expect variable. This keeps existing behavior when Chai is available, and ensures that when Chai is not available, tests can still use a global expect compatible with typical Chai syntax.

Concretely, in run-locale-tests.js, inside the catch block where the fallback is defined (around line 14), change the assignment from:

expect = (val) => ({ ... });

to something like:

expect = global.expect = (val) => ({ ... });

This preserves the local variable (satisfying any potential local usages) and ensures that the tests loaded later can access expect via the global object. No new imports or additional helpers are required; global is a standard Node.js global object.

@@ -0,0 +1,68 @@
+// Standalone test runner for locale tests
+const fs = require('fs');


In general, the fix for an unused variable or import is to either remove it or start using it. Since there is no indication that fs is needed, the safest and simplest fix is to remove the unused fs import.

Concretely, in run-locale-tests.js, delete the line that declares const fs = require('fs'); at the top of the file. No other code changes or imports are required, because nothing in the shown code references fs. This preserves all existing functionality while eliminating the unused variable flagged by CodeQL.

@@ -0,0 +1,68 @@
+// Standalone test runner for locale tests
+const fs = require('fs');
+const path = require('path');


In general, to fix an "unused variable/import" warning, either remove the unused binding or start using it meaningfully if it was actually intended to be used. Here, path is a Node core module that is never used in run-locale-tests.js, and importing it has no side effects, so the correct fix is to remove the unused variable entirely.

The single best fix is to delete the const path = require('path'); line from run-locale-tests.js. This avoids changing any other behavior: no other code references path, and Node’s path module does not perform side effects on import. No new methods, imports, or definitions are required; we simply remove that one line.

Concretely:

Edit run-locale-tests.js.

Remove line 3: const path = require('path');.

Leave all other lines as they are.

+// Standalone test runner for locale tests
+const fs = require('fs');
+const path = require('path');
+const yaml = require('js-yaml');


In general, to fix an "unused variable/import" issue, you either remove the declaration/import if it’s genuinely unused, or you add the missing usage if the code was incomplete. Here, the imported yaml symbol is not used anywhere, and there is no indication that it is intended to be used for side effects.

The best fix without changing behavior is to remove the yaml variable and its require('js-yaml') call. This means deleting line 4 from run-locale-tests.js. No additional methods, imports, or definitions are needed, and no other lines need to change. The file will continue to work as a test runner using fs, path, and the test framework, but will no longer pull in an unused dependency.

+const fs = require('fs');
+const path = require('path');
+const yaml = require('js-yaml');
+const { describe, it } = require('node:test');


In general, unused imports or variables should be removed to improve readability and avoid confusion. Here, describe is imported from node:test but never used, while it may still be required by the imported test file or might also be unused (but CodeQL only flagged describe). The minimal, behavior‑preserving fix is to stop destructuring describe and only import what is (or may be) used.

Concretely, in run-locale-tests.js, adjust line 5 so that it only imports it from node:test (or remove the entire import if neither describe nor it is used anywhere in this file). To keep changes minimal and avoid assumptions about it’s use elsewhere, we will change:

const { describe, it } = require('node:test');

to:

const { it } = require('node:test');

No additional methods, imports, or definitions are needed.

+const fs = require('fs');
+const path = require('path');
+const yaml = require('js-yaml');
+const { describe, it } = require('node:test');


In general, unused imported bindings should be removed from the import statement to keep the code clean and avoid confusion. Here, we keep the import from node:test but only import the symbol that is or may be used (describe), and drop it.

Concretely, in run-locale-tests.js, at the top of the file, adjust the destructuring require on line 5 so that it only imports describe from node:test instead of both describe and it. No other code changes or new definitions are needed.

hydro-dev-bot · 2025-12-21T04:33:58Z

Thank you for your submission, we really appreciate it.
Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Comment I have read the CLA Document and I hereby sign the CLA below to sign it.

CodeRabbit Generated Unit Tests: Add zh_TW locale validation test suite

ec23169

github-advanced-security AI found potential problems Dec 21, 2025

View reviewed changes

Fix UTG issues (iteration 1)

fdb1266

coderabbitai Bot closed this Dec 21, 2025

coderabbitai Bot deleted the coderabbitai/utg/2f0b147 branch December 21, 2025 04:53

coderabbitai Bot mentioned this pull request Dec 21, 2025

Add missing zh_TW translations for error messages and UI strings #1099

Merged

@@ -64,5 +64,7 @@
                 });
             }
+            global.expect = expect;
             // Load the test file
             require('./packages/hydrooj/tests/locale.spec.ts');

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

CodeRabbit Generated Unit Tests: Add zh_TW locale validation test suite#1101

CodeRabbit Generated Unit Tests: Add zh_TW locale validation test suite#1101
coderabbitai[bot] wants to merge 2 commits into
masterfrom
coderabbitai/utg/2f0b147

coderabbitai Bot commented Dec 21, 2025

Uh oh!

coderabbitai Bot commented Dec 21, 2025

Review skipped

Uh oh!

hydro-dev-bot Bot commented Dec 21, 2025

Uh oh!

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

hydro-dev-bot Bot commented Dec 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		@@ -0,0 +1,68 @@
		// Standalone test runner for locale tests
		const fs = require('fs');

Uh oh!

Uh oh!

Conversation

coderabbitai Bot commented Dec 21, 2025

Uh oh!

coderabbitai Bot commented Dec 21, 2025

Review skipped

Uh oh!

hydro-dev-bot Bot commented Dec 21, 2025

Uh oh!

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

hydro-dev-bot Bot commented Dec 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant