apply eslint and typescript checks on tests too (#464)

* apply eslint and typescript cheks on tests too

* simplify config

Author: severo

eslint.config.js

@@ -76,7 +76,7 @@ export default defineConfig([
     files: ['**/*.{ts,tsx}'],
     languageOptions: {
       parserOptions: {
-        project: ['./tsconfig.eslint.json'],
+        project: ['./tsconfig.json'],
         tsconfigRootDir: import.meta.dirname,
       },
     },

package.json

@@ -37,15 +37,15 @@
   ],
   "scripts": {
     "build:bundle": "vite build",
-    "build:types": "tsc -b",
+    "build:types": "tsc -p tsconfig.build.json",
     "build": "npm run build:bundle && npm run build:types",
     "coverage": "vitest run --coverage --coverage.include=src --coverage.exclude=src/**/*.stories.tsx",
     "lint": "eslint",
     "lint:fix": "eslint --fix",
     "prepublishOnly": "npm run build",
     "storybook": "storybook dev -p 6006 --disable-telemetry",
     "test": "vitest run",
-    "typecheck": "tsc --noEmit"
+    "typecheck": "tsc"
   },
   "devDependencies": {
     "@eslint/compat": "2.0.2",

test/helpers/dataframe/array.test.ts

@@ -105,7 +105,11 @@ describe('arrayDataFrame', () => {
     df.eventTarget?.addEventListener('update', resolveListener)
 
     // when a property of an array element (a cell) is changed, no event is dispatched, because the proxy is shallow
-    df._array[0].name = 'Alicia'
+    const originalRow = df._array[0]
+    if (originalRow === undefined) {
+      throw new Error('Original row is undefined')
+    }
+    originalRow.name = 'Alicia'
     expect(resolveListener).toHaveBeenCalledTimes(0)
     expect(df.getCell({ row: 0, column: 'name' })?.value).toBe('Alicia')
   })

test/providers/DataProvider.test.tsx

@@ -198,6 +198,9 @@ describe('DataProvider', () => {
       expect(getByTestId('column-descriptors').textContent).toBe(initialColumnDescriptors)
       // Change the column descriptors in the data frame
       data.columnDescriptors.push({ name: 'c', sortable: true })
+      if (data.columnDescriptors[0] === undefined || data.columnDescriptors[1] === undefined) {
+        throw new Error('Not enough column descriptors')
+      }
       data.columnDescriptors[0].name = 'x'
       data.columnDescriptors[1].sortable = true
       // force a re-render without changing the data frame instance

tsconfig.build.json

@@ -0,0 +1,27 @@
+{
+  "compilerOptions": {
+    "target": "esnext",
+    "useDefineForClassFields": true,
+    "lib": ["ES2022", "DOM", "DOM.Iterable"],
+    "module": "ESNext",
+    "skipLibCheck": true,
+
+    "moduleResolution": "bundler",
+    "isolatedModules": true,
+    "moduleDetection": "force",
+    "jsx": "react-jsx",
+
+    "strict": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "noFallthroughCasesInSwitch": true,
+    "noUncheckedSideEffectImports": true,
+    "noUncheckedIndexedAccess": true,
+
+    "rootDir": "src",
+    "outDir": "dist/types",
+    "emitDeclarationOnly": true,
+    "declaration": true
+  },
+  "include": ["src"]
+}

tsconfig.eslint.json

@@ -1,28 +1,15 @@
 {
+  "extends": "./tsconfig.build.json",
   "compilerOptions": {
-    "tsBuildInfoFile": "./node_modules/.tmp/tsconfig.tsbuildinfo",
-    "target": "esnext",
-    "useDefineForClassFields": true,
-    "lib": ["ES2022", "DOM", "DOM.Iterable"],
-    "module": "ESNext",
-    "skipLibCheck": true,
-
-    "moduleResolution": "bundler",
-    "isolatedModules": true,
-    "moduleDetection": "force",
-    "jsx": "react-jsx",
-
-    "strict": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": true,
-    "noFallthroughCasesInSwitch": true,
-    "noUncheckedSideEffectImports": true,
-    "noUncheckedIndexedAccess": true,
-
-    "rootDir": "src",
-    "outDir": "dist/types",
-    "emitDeclarationOnly": true,
-    "declaration": true
+    "noEmit": true,
+    "rootDir": "."
   },
-  "include": ["src"]
+  "include": [
+    "src",
+    "test",
+    "**/*.js",
+    "**/*.ts",
+    "**/*.tsx",
+    "**/.storybook/*.ts"
+  ]
 }