Skip to content

apply eslint and typescript checks on tests too#464

Merged
severo merged 2 commits into
masterfrom
typescript-for-tests
Mar 6, 2026
Merged

apply eslint and typescript checks on tests too#464
severo merged 2 commits into
masterfrom
typescript-for-tests

Conversation

@severo

@severo severo commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@severo severo requested a review from Copilot March 6, 2026 09:34
@severo severo changed the title apply eslint and typescript cheks on tests too apply eslint and typescript checks on tests too Mar 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restructures TypeScript config usage so that both ESLint’s type-aware rules and tsc typechecking cover the test/ directory, while keeping the declaration build limited to src/.

Changes:

  • Split TS configs into a build-focused tsconfig.build.json and a repo-wide tsconfig.json (noEmit) that includes tests.
  • Remove tsconfig.eslint.json and point ESLint’s parserOptions.project at tsconfig.json.
  • Update scripts and adjust a couple tests for stricter indexed access typing.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tsconfig.json Makes tsc/ESLint type-aware checks include test/ (and broader globs) with noEmit.
tsconfig.eslint.json Removed in favor of using tsconfig.json directly.
tsconfig.build.json New build-only TS config used for declaration output (dist/types).
test/providers/DataProvider.test.tsx Adds guard to satisfy strict indexed access typing.
test/helpers/dataframe/array.test.ts Adds guard to satisfy strict indexed access typing.
package.json Uses tsconfig.build.json for type build; typecheck now runs plain tsc.
eslint.config.js Points type-aware TS ESLint config to tsconfig.json.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tsconfig.build.json
Comment thread tsconfig.build.json Outdated
Comment thread test/providers/DataProvider.test.tsx
Comment thread test/helpers/dataframe/array.test.ts
@severo severo merged commit 32f1635 into master Mar 6, 2026
5 checks passed
@severo severo deleted the typescript-for-tests branch March 6, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants