apply eslint and typescript checks on tests too#464
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restructures TypeScript config usage so that both ESLint’s type-aware rules and tsc typechecking cover the test/ directory, while keeping the declaration build limited to src/.
Changes:
- Split TS configs into a build-focused
tsconfig.build.jsonand a repo-widetsconfig.json(noEmit) that includes tests. - Remove
tsconfig.eslint.jsonand point ESLint’sparserOptions.projectattsconfig.json. - Update scripts and adjust a couple tests for stricter indexed access typing.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Makes tsc/ESLint type-aware checks include test/ (and broader globs) with noEmit. |
| tsconfig.eslint.json | Removed in favor of using tsconfig.json directly. |
| tsconfig.build.json | New build-only TS config used for declaration output (dist/types). |
| test/providers/DataProvider.test.tsx | Adds guard to satisfy strict indexed access typing. |
| test/helpers/dataframe/array.test.ts | Adds guard to satisfy strict indexed access typing. |
| package.json | Uses tsconfig.build.json for type build; typecheck now runs plain tsc. |
| eslint.config.js | Points type-aware TS ESLint config to tsconfig.json. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.