fix lint and test

Author: bleakley

src/components/File/File.test.tsx

@@ -44,9 +44,16 @@ describe('File Component', () => {
     const source = getHttpSource(url)
     assert(source?.kind === 'file')
 
-    const { getByText } = await act(() => render(<File source={source} />))
+    const { getAllByRole } = await act(() => render(
+      <ConfigProvider value={config}>
+        <File source={source} />
+      </ConfigProvider>
+    ))
 
-    expect(getByText(url)).toBeDefined()
+    const links = getAllByRole('link')
+    expect(links[0]?.getAttribute('href')).toBe('/')
+    expect(links[1]?.getAttribute('href')).toBe('/files?key=https://example.com/')
+    expect(links[2]?.getAttribute('href')).toBe('/files?key=https://example.com/test.txt')
   })
 
   it('renders correct breadcrumbs for nested folders', async () => {

src/lib/sources/httpSource.ts

@@ -1,7 +1,7 @@
 import { DirSource, FileMetadata, FileSource, SourcePart } from './types.js'
 import { getFileName } from './utils.js'
 
-function s3listv2(bucket: string, prefix: string) {
+function s3list(bucket: string, prefix: string) {
   const url = `https://${bucket}.s3.amazonaws.com/?list-type=2&prefix=${prefix}&delimiter=/`
   return fetch(url)
     .then(res => {
@@ -58,7 +58,6 @@ function getSourceParts(sourceId: string): SourcePart[] {
     ? [`${protocol}://${rest.split('/', 1)[0]}`, ...rest.split('/').slice(1)]
     : sourceId.split('/')
   const sourceParts = [
-    //{ 'text': '/', 'sourceId': '' },
     ...parts.map((part, depth) => {
       const slashSuffix = depth === parts.length - 1 ? '' : '/'
       return {
@@ -94,13 +93,17 @@ export function getHttpSource(sourceId: string, options?: {requestInit?: Request
       sourceId,
       sourceParts,
       prefix,
-      listFiles: () => s3listv2(bucket, prefix).then(items =>
+      listFiles: () => s3list(bucket, prefix).then(items =>
         items
           .filter(item => item.key !== undefined)
           .map(item => {
-            const isDirectory = item.key!.endsWith('/')
+            if (!item.key) {
+              throw new Error('Key is undefined')
+            }
+            const isDirectory = item.key.endsWith('/')
             const itemSourceId = `https://${bucket}.s3.amazonaws.com/${item.key}`
-            let name = item.key!.split('/').pop() || item.key
+            // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
+            let name = item.key.split('/').pop() || item.key
             if (name && isDirectory) {
               name = name.replace(prefix, '')
             }