Skip to content

Disable opening the browser when in development mode #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
severo merged 3 commits into from
Mar 10, 2025
Merged

Disable opening the browser when in development mode #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b58041
remove dead code
severo Mar 10, 2025
fea8ab0
nit: fix variable name
severo Mar 10, 2025
c038fe2
disable opening the page in browser when in development mode
severo Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions bin/serve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,13 @@ export async function serve(serveDirectory, key) {
}
}
console.log(`hyperparam server running on http://localhost:${port}`)
if (!key) openUrl(`http://localhost:${port}`)
else {
key = encodeURIComponent(key)
openUrl(`http://localhost:${port}/files?key=${key}`)
const isDev = process.env.NODE_ENV === 'development'
if (!isDev) {
if (!key) openUrl(`http://localhost:${port}`)
else {
key = encodeURIComponent(key)
openUrl(`http://localhost:${port}/files?key=${key}`)
}
}
}

Expand Down Expand Up @@ -91,15 +94,12 @@ function handleRequest(req, serveDirectory) {
} else if (pathname.startsWith('/assets/') || pathname.startsWith('/favicon') ) {
// serve static files
return handleStatic(`${hyperparamPath}/dist${pathname}`)
// else if (pathname.startsWith('/public/')) {
// // serve static files
// return handleStatic(`${hyperparamPath}${pathname.replace(/^(\/public).*/, '/dist')}`)
} else if (serveDirectory && pathname === '/api/store/list') {
// serve file list
const prefix = parsedUrl.query.prefix || ''
if (Array.isArray(prefix)) return { status: 400, content: 'bad request' }
const perfixPath = `${serveDirectory}/${decodeURIComponent(prefix)}`
return handleListing(perfixPath)
const prefixPath = `${serveDirectory}/${decodeURIComponent(prefix)}`
return handleListing(prefixPath)
} else if (serveDirectory && pathname === '/api/store/get') {
// serve file content
const key = parsedUrl.query.key || ''
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
"url": "run-p -l watch:ts watch:vite watch:url",
"watch:ts": "tsc --watch",
"watch:vite": "vite build --watch",
"watch:serve": "nodemon bin/cli.js",
"watch:url": "nodemon bin/cli.js https://hyperparam.blob.core.windows.net/hyperparam/starcoderdata-js-00000-of-00065.parquet"
"watch:serve": "NODE_ENV=development nodemon bin/cli.js",
"watch:url": "NODE_ENV=development nodemon bin/cli.js https://hyperparam.blob.core.windows.net/hyperparam/starcoderdata-js-00000-of-00065.parquet"
},
"dependencies": {
"hightable": "0.12.1",
Expand Down