Skip to content

Export more components#223

Merged
platypii merged 1 commit intomasterfrom
more-exports
Apr 22, 2025
Merged

Export more components#223
platypii merged 1 commit intomasterfrom
more-exports

Conversation

@platypii
Copy link
Copy Markdown
Contributor

Exporting more components makes it easier to hack on the demos etc.

Also resolve rowgroup indexes a little sooner.

Also resolve rowgroup indexes a little sooner.
@platypii platypii requested a review from severo April 22, 2025 19:50
Comment thread src/components/index.ts
import VisuallyHidden from './VisuallyHidden/VisuallyHidden.js'
import Welcome from './Welcome/Welcome.js'

export {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this format is better

Comment thread src/lib/tableProvider.ts
// Initialize with resolvable promises
for (let i = rowStart; i < rowEnd; i++) {
data[i] = resolvableRow(header)
data[i]?.index.resolve(i)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@platypii platypii merged commit 977df82 into master Apr 22, 2025
4 checks passed
@platypii platypii deleted the more-exports branch April 22, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants