[BUG] fix _score_params + add tests + fix errors 'masked' by the 'try… #20
SimonBlankeAnnotations
2 errors and 4 warnings
|
update_draft
HttpError: Resource not accessible by integration
at /home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:7146:21
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Job.doExecute (/home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:61885:18)
{
name: 'AggregateError',
event: {
id: '22229664188',
name: 'push',
payload: {
after: 'b8ecdf1055fd72cac2a45cb56bc369f9d421c89e',
base_ref: null,
before: '7e049cbe77682232b018bf2983f917db34374977',
commits: [
{
author: {
email: 'simon.blanke.opensource@gmail.com',
name: 'Simon Blanke',
username: 'SimonBlanke'
},
committer: {
email: 'noreply@github.com',
name: 'GitHub',
username: 'web-flow'
},
distinct: true,
id: 'b8ecdf1055fd72cac2a45cb56bc369f9d421c89e',
message: "[BUG] fix _score_params + add tests + fix errors 'masked' by the 'try... except'-block (#237)\n" +
'\n' +
'### Bug fix: `_score_params` passed parameters incorrectly\n' +
'\n' +
'`_score_params` called `experiment(**params)`, unpacking the dict as\n' +
'keyword arguments. `BaseExperiment.__call__` expects a single positional\n' +
'dict, so every call raised a `TypeError` that was silently swallowed by\n' +
'the bare `except` clause. All candidates received `error_score` (NaN)\n' +
'and `np.argmax` always picked index 0, making optimization results\n' +
'appear stable but entirely meaningless.\n' +
'\n' +
'Fixed by changing `experiment(**params)` to `experiment(params)`. The\n' +
'`except` clause now also emits a `warnings.warn` so caught exceptions\n' +
'are no longer silent.\n' +
'\n' +
'### Fix: deterministic test parameters for `TSCOptCV`\n' +
'\n' +
'The corrected `_score_params` exposed non-determinism in\n' +
'`TSCOptCV.get_test_params`: the `"stratified"` DummyClassifier strategy\n' +
'produces random predictions, and the default CV used `shuffle=True`\n' +
'without a fixed seed. Together these caused `test_fit_idempotent` to\n' +
'fail intermittently.\n' +
'\n' +
'Fixed by replacing `"stratified"` with `"prior"` (deterministic) and\n' +
'pinning `cv=KFold(n_splits=2, shuffle=False)`.\n' +
'\n' +
'### Enhancement: `_predict_proba` override for `TSCOptCV`\n' +
'\n' +
'`TSCOptCV` overrode `_predict` with a `refit=False` guard but left\n' +
'`_predict_proba` unoverridden. With `refit=False`, `predict` raised\n' +
'`RuntimeError` while `predict_proba` silently delegated to an unfitted\n' +
'estimator. Added the same guard to `_predict_proba`.\n' +
'\n' +
'### Tests\n' +
'\n' +
'Added unit tests for `_score_params` covering correct dict passing,\n' +
'return type, error score fallback, and warning emission.',
timestamp: '2026-02-20T16:18:12+01:00',
tree_id: '8650283c83d9de9a764636fa77cc2ad8efb2e360',
url: 'https://github.com/hyperactive-project/Hyperactive/commit/b8ecdf1055fd72cac2a45cb56bc369f9d421c89e'
}
],
compare: 'https://github.com/hyperactive-project/Hyperactive/compare/7e049cbe7768...b8ecdf1055fd',
created: false,
deleted: false,
forced: false,
head_commit: {
author: {
email: 'simon.blanke.opensource@gmail.com',
name: 'Simon Blanke',
username: 'SimonBlanke'
},
committer: {
email: 'noreply@github.com',
name: 'GitHub',
username: 'web-flow'
},
distinct: true,
id: 'b8ecdf1055fd72cac2a45cb56bc369f9d421c89e',
message:
|
|
update_draft
Resource not accessible by integration
{
name: 'HttpError',
id: '22229664188',
status: 403,
response: {
url: 'https://api.github.com/repos/hyperactive-project/Hyperactive/releases',
status: 403,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
'content-encoding': 'gzip',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Fri, 20 Feb 2026 15:18:25 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'github.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
'transfer-encoding': 'chunked',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-github-permissions': 'contents=write; contents=write,workflows=write',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-api-version-selected': '2022-11-28',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': '7800:1AFE8C:26560A5:2721DDD:69987B41',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4997',
'x-ratelimit-reset': '1771604302',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '3',
'x-xss-protection': '0'
},
data: {
message: 'Resource not accessible by integration',
documentation_url: 'https://docs.github.com/rest/releases/releases#create-a-release',
status: '403'
}
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/hyperactive-project/Hyperactive/releases',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'probot/12.4.0 octokit-core.js/3.6.0 Node.js/20.19.6 (linux; x64)',
'x-github-delivery': '22229664188',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: `{"target_commitish":"refs/heads/main","name":"v5.0.4","tag_name":"v5.0.4","body":"## What's Changed\\n\\n* [BUG] fix _score_params + add tests + fix errors 'masked' by the 'try... except'-block (#237) @SimonBlanke\\n\\n**Full Changelog**: https://github.com/hyperactive-project/Hyperactive/compare/v5.0.3...v5.0.4\\n","draft":true,"prerelease":false,"make_latest":"true"}`,
request: {}
},
event: {
id: '22229664188',
name: 'push',
payload: {
after: 'b8ecdf1055fd72cac2a45cb56bc369f9d421c89e',
base_ref: null,
before: '7e049cbe77682232b018bf2983f917db34374977',
commits: [
{
author: {
email: 'simon.blanke.opensource@gmail.com',
name: 'Simon Blanke',
username: 'SimonBlanke'
},
committer: {
email: 'noreply@github.com',
name: 'GitHub',
username: 'web-flow'
},
distinct: true,
id: 'b8ecdf1055fd72cac2a45cb56bc369f9d421c89e',
message: "[BUG] fix _score_params + add tests + fix errors 'masked' by the 'try... except'-block (#237)\n" +
'\n' +
'### Bug fix: `_score_params` passed parameters incorrectly\n' +
'\n' +
'`_score_params` called `experiment(**params)`, unpacking the dict as\n' +
'keyword arguments. `BaseExperiment.__call__` expects a single positional\n' +
'dict, so every call raised a `TypeError` that was silently swallowed by\n' +
'the bare `except` clause. All candidates received `error_score` (NaN)\n' +
'and `np.argmax` always picked index 0, making optimization results\n' +
'appear stable but entirely meaningless.\n' +
'\n' +
'Fixed by changing `experiment(**params)` to `experiment(params)`. The
|
|
update_draft
"pull_request_target.edited" is not a known webhook name (https://developer.github.com/v3/activity/events/types/)
|
|
update_draft
"pull_request_target.synchronize" is not a known webhook name (https://developer.github.com/v3/activity/events/types/)
|
|
update_draft
"pull_request_target.reopened" is not a known webhook name (https://developer.github.com/v3/activity/events/types/)
|
|
update_draft
"pull_request_target.opened" is not a known webhook name (https://developer.github.com/v3/activity/events/types/)
|