Skip to content

Commit 0595bd5

Browse files
authored
[BUG] fix params ignored in SktimeForecastingExperiment (#175)
fixes an unreported bug where the `params` in `_evaluate` were ignored, in `SktimeForecastingExperiment`. This is fixed by cloning `forecaster` and setting the parameters.
1 parent 933a0dd commit 0595bd5

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

src/hyperactive/experiment/integrations/sktime_forecasting.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,8 +210,10 @@ def _evaluate(self, params):
210210
"""
211211
from sktime.forecasting.model_evaluation import evaluate
212212

213+
forecaster = self.forecaster.clone().set_params(**params)
214+
213215
results = evaluate(
214-
self.forecaster,
216+
forecaster,
215217
cv=self.cv,
216218
y=self.y,
217219
X=self.X,

0 commit comments

Comments
 (0)