Fix ruff issues: add docstrings, wrap long lines, use union isinstance

Author: arnavk23

src/hyperactive/experiment/integrations/sktime_detector.py

@@ -1,3 +1,9 @@
+"""Integration adapter for sktime detector experiments.
+
+Provides `SktimeDetectorExperiment` which adapts sktime detector-style
+objects to the Hyperactive experiment interface.
+"""
+
 import numpy as np
 from skbase.utils.dependencies import _check_soft_dependencies
 
@@ -118,16 +124,16 @@ def _evaluate(self, params):
             return res_float, {"results": results}
 
         # Fallback: perform a manual cross-validation loop if `evaluate` is not present.
-        from sklearn.base import clone as skl_clone
 
         # Determine underlying metric function or sklearn-style scorer
         metric_func = getattr(self._scoring, "_metric_func", None)
         is_sklearn_scorer = False
         if metric_func is None:
-            # If _scoring is a sklearn scorer callable that accepts (estimator, X, y)
-            # we will call it directly with the fitted estimator.
+            # If _scoring is a sklearn scorer callable that accepts
+            # (estimator, X, y) we will call it directly with the fitted estimator.
             if callable(self._scoring):
-                # heuristics: sklearn scorers produced by make_scorer take (estimator, X, y)
+                # Heuristic: sklearn scorers produced by `make_scorer` take
+                # arguments `(estimator, X, y)`.
                 is_sklearn_scorer = True
         else:
             metric = metric_func
@@ -138,7 +144,7 @@ def _evaluate(self, params):
             for train_idx, test_idx in self._cv.split(self.y):
                 X_train = None
                 X_test = None
-                if isinstance(self.y, (list, tuple)):
+                if isinstance(self.y, list | tuple):
                     y_train = [self.y[i] for i in train_idx]
                     y_test = [self.y[i] for i in test_idx]
                 else:
@@ -200,10 +206,10 @@ def _evaluate(self, params):
         return float(res_float), {"results": {"cv_scores": scores}}
 
     def _safe_index(self, obj, idx):
-        """
-        Safely index into `obj` using integer indices.
+        """Safely index into `obj` using integer indices.
 
-        Supports pandas objects with .iloc, numpy arrays/lists, and other indexable types.
+        Supports pandas objects with ``.iloc``, numpy arrays/lists, and other
+        indexable types.
         """
         try:
             return obj.iloc[idx]
@@ -218,7 +224,11 @@ def _safe_index(self, obj, idx):
 
     @classmethod
     def get_test_params(cls, parameter_set="default"):
-        # Return testing parameter settings for the skbase object.
+        """Return testing parameter settings for the skbase object.
+
+        This returns a list or dict appropriate to construct test instances
+        for this class. See the skbase test helpers for expected formats.
+        """
         if _check_soft_dependencies("sktime", severity="none"):
             try:
                 from sktime.annotation.dummy import DummyDetector

src/hyperactive/experiment/integrations/tests/test_sktime_detector_experiment.py

@@ -1,4 +1,8 @@
+"""Smoke tests for the sktime detector experiment integration."""
+
+
 def test_sktime_detector_experiment_with_dummy():
+    """Run a minimal smoke test using sktime's DummyDetector (if available)."""
     try:
         from sktime.annotation.dummy import DummyDetector
         from sktime.datasets import load_unit_test

src/hyperactive/integrations/sktime/_detector.py

@@ -107,10 +107,12 @@ def get_test_params(cls, parameter_set="default"):
             "optimizer": GridSearchSk(param_grid={}),
         }
 
-        
+
         params_more = {
             "detector": DummyDetector() if DummyDetector is not None else None,
-            "optimizer": GridSearchSk(param_grid={"strategy": ["most_frequent", "stratified"]}),
+            "optimizer": GridSearchSk(
+                param_grid={"strategy": ["most_frequent", "stratified"]}
+            ),
             "cv": 2,
             "scoring": None,
             "refit": False,

src/hyperactive/integrations/sktime/tests/test_detector_integration.py

@@ -1,4 +1,8 @@
+"""Basic import smoke tests for the sktime detector integration."""
+
+
 def test_detector_integration_imports():
+    """Ensure the public integration symbols can be imported."""
     from hyperactive.experiment.integrations import SktimeDetectorExperiment
     from hyperactive.integrations.sktime import TSDetectorOptCv