chore(auth): clarify login form readiness guard

Author: Kzoeps

packages/auth-service/src/__tests__/login-page.test.ts

@@ -522,11 +522,11 @@ function renderDefault(): string {
 }
 
 describe('renderLoginPage email form readiness gate', () => {
-  it('renders the email OTP form as not ready until JavaScript enables it', () => {
+  it('renders the email OTP form without a readiness dataset marker', () => {
     const html = renderDefault()
-    expect(html).toContain(
-      '<form id="form-send-otp" data-epds-login-ready="false">',
-    )
+    expect(html).toContain('<form id="form-send-otp">')
+    expect(html).not.toContain('data-epds-login-ready')
+    expect(html).not.toContain('epdsLoginReady')
   })
 
   it('renders the email submit button disabled with the existing label', () => {
@@ -536,17 +536,13 @@ describe('renderLoginPage email form readiness gate', () => {
     )
   })
 
-  it('marks the form ready and enables the button after handler setup', () => {
+  it('enables the button after handler setup', () => {
     const html = renderDefault()
     const lastHandlerIdx = html.lastIndexOf("addEventListener('click'")
-    const readyIdx = html.indexOf(
-      "sendOtpForm.dataset.epdsLoginReady = 'true';",
-    )
-    const enableIdx = html.indexOf('sendOtpBtn.disabled = false;', readyIdx)
+    const enableIdx = html.indexOf('sendOtpBtn.disabled = false;')
 
     expect(lastHandlerIdx).toBeGreaterThan(0)
-    expect(readyIdx).toBeGreaterThan(lastHandlerIdx)
-    expect(enableIdx).toBeGreaterThan(readyIdx)
+    expect(enableIdx).toBeGreaterThan(lastHandlerIdx)
   })
 
   it('does not use a blind timeout for readiness', () => {

packages/auth-service/src/routes/login-page.ts

@@ -660,7 +660,7 @@ export function renderLoginPage(opts: {
 
     <!-- Step 1: Email entry (calls better-auth sendOtp) -->
     <div id="step-email" class="step-email${opts.initialStep === 'otp' ? ' hidden' : ''}">
-      <form id="form-send-otp" data-epds-login-ready="false">
+      <form id="form-send-otp">
         <div class="field">
           <label for="email">Enter your email address</label>
           <input type="email" id="email" name="email" required autofocus
@@ -1165,7 +1165,8 @@ export function renderLoginPage(opts: {
         clearOtpBoxes();
       });
 
-      sendOtpForm.dataset.epdsLoginReady = 'true';
+      // Enable only after the submit handler is installed. This avoids a race mostly
+      // seen in fast e2e runs where the button is clicked before JS is ready.
       sendOtpBtn.disabled = false;
 
       // Pillar 1: If login_hint was provided, the OTP step is already visible